From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114939: * lisp/progmodes/ruby-mode.el (ruby-mode): Clean up docstring. Date: Mon, 04 Nov 2013 11:43:21 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383583419 15594 80.91.229.3 (4 Nov 2013 16:43:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Nov 2013 16:43:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 04 17:43:43 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VdNFe-0004XN-UL for ged-emacs-devel@m.gmane.org; Mon, 04 Nov 2013 17:43:43 +0100 Original-Received: from localhost ([::1]:50911 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdNFe-0005h3-Gq for ged-emacs-devel@m.gmane.org; Mon, 04 Nov 2013 11:43:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdNFV-0005fh-Dm for emacs-devel@gnu.org; Mon, 04 Nov 2013 11:43:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdNFN-0002WQ-9r for emacs-devel@gnu.org; Mon, 04 Nov 2013 11:43:33 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:24209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdNFN-0002W5-5i for emacs-devel@gnu.org; Mon, 04 Nov 2013 11:43:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLzd/2dsb2JhbABEvw4Xc4IfAQVWIxALNBIUGA0kiCTBLZEKA4hhnBmBXoMV X-IPAS-Result: Av4EABK/CFFFxLzd/2dsb2JhbABEvw4Xc4IfAQVWIxALNBIUGA0kiCTBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37052346" Original-Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Nov 2013 11:43:24 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 135C96012B; Mon, 4 Nov 2013 11:43:22 -0500 (EST) In-Reply-To: (Bozhidar Batsov's message of "Mon, 04 Nov 2013 14:21:19 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164932 Archived-At: > +Entry to this mode calls the value of `ruby-mode-hook' > +if that value is non-nil." That's problematic: - it's redundant since define-derived-mode already adds "In addition to any hooks its parent mode `prog-mode' might have run,\nthis mode runs the hook `ruby-mode-hook', as the final step\nduring initialization." - hooks aren't "called" but are "run". - it's not just "the value of `ruby-mode-hook'", but the *values*, since hooks use both the buffer-local and the global value of the symbol. - the hook is run even if it is nil (or unbound): running it will simply not do anything. Stefan