Many warning building master

Many warning building master

[Angelo Graziosi]

I wonder if someone noticed the number of warnings building current master.

I always do clean build from emacs-master.tar.gz and my previous build 
log file (master-450beba, on Feb 24) has a size of 343860 bytes.  With 
current master (bfebebb) the size is 455854 bytes, about +30%.

For example I notice many warnings of the type:

   attempt to open-code `anonymous
     lambda' with too few arguments

   `show-entry' is an obsolete function (as of 25.1);
     use `outline-show-entry' instead.


    ...


I notice this on Cygwin (--with-w32) but I think it is general.


Ciao,
  Angelo.

Re: Many warning building master

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 135 bytes --]

Most warnings were introduced when the outline functions were given proper
prefixes. I think the vast majority of these come from org.

[-- Attachment #2: Type: text/html, Size: 153 bytes --]

Re: Many warning building master

[Stefan Monnier]

>   attempt to open-code `anonymous
>     lambda' with too few arguments

These are new and need to be fixed.  The corresponding fix is probably
in bytecomp.el.


        Stefan

Re: Many warning building master

[Angelo Graziosi]

Stefan Monnier wrote:
>>   attempt to open-code `anonymous
>>     lambda' with too few arguments
> These are new and need to be fixed.

Indeed. I have verified that in the build log I did on linux, master 
March 03, those warnings are absent.

Ciao,
  Angelo.

Re: Many warning building master

[Stefan Monnier]

> Indeed. I have verified that in the build log I did on linux, master March
> 03, those warnings are absent.

They should be absent again, now.


        Stefan

Re: Many warning building master

[Angelo Graziosi]

Il 10/03/2015 02:27, Stefan Monnier ha scritto:
>> Indeed. I have verified that in the build log I did on linux, master March
>> 03, those warnings are absent.
>
> They should be absent again, now.


Ok, but there are still a lot of warnings like this:

   :Warning: `x-get-selection' is an obsolete function (as of
     25.1); use `gui-get-selection' instead.


$ grep -c 'as of 25.1); use' emacs-build.log
382

(at least, they have not been introduced recently... seems..)


Ciao,
  Angelo.

Re: Many warning building master

[Stefan Monnier]

> Ok, but there are still a lot of warnings like this:
>   :Warning: `x-get-selection' is an obsolete function (as of
>     25.1); use `gui-get-selection' instead.

Yes, indeed.  These are real and point to code using an older API.
Since this change is new in Emacs-25.1, there can be very valid reasons
to keep using the old API for now (for code which is also distributed
outside of Emacs).  But it should be fixed for all code which is not
distributed outside of Emacs.


        Stefan