unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: dannyfreeman <danny@dfreeman.email>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/jarchive 2eb44fdf37: Add info to README about ELPA
Date: Sun, 13 Nov 2022 17:39:07 -0500	[thread overview]
Message-ID: <jwv7czyjxdg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20221113215745.B3209C00AB5@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Sun, 13 Nov 2022 16:57:45 -0500 (EST)")

>  
>  ``` emacs-lisp
>  (require 'jarchive)

BTW, this was not changed in the above commit, but `require` should
basically never be needed in a user's init file.
And indeed if we look at the above sample in its entirety:

    ``` emacs-lisp
    (require 'jarchive)
    (with-eval-after-load "init"
      (jarchive-setup))
    ```

we see that `require` is not needed since `jarchive-setup`
is autoloaded.

I also fail to see why you need to wrap it in `(with-eval-after-load
"init" ...)`, especially since that will fail for the users who don't have an
`init.el` (those who use `early-init.el` or `~/.emacs` instead).


        Stefan




           reply	other threads:[~2022-11-13 22:39 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20221113215745.B3209C00AB5@vcs2.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7czyjxdg.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=danny@dfreeman.email \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).