From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Campbell Barton <ideasman42@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/meow 9860a7a218: Correct unused lexical variable (#411)
Date: Fri, 10 Mar 2023 14:40:37 -0500 [thread overview]
Message-ID: <jwv7cvoe6t9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20230310010125.5A435C13A88@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Thu, 9 Mar 2023 20:01:25 -0500 (EST)")
> @@ -1636,7 +1636,7 @@ This command is a replacement for built-in `kmacro-end-macro'."
> (interactive (list (help--read-key-sequence)))
> (if (= 1 (length key-list))
> (let* ((key (format-kbd-macro (cdar key-list)))
> - (cmd (key-binding (cdar key-list))))
> + (cmd (key-binding key)))
Hmm... that doesn't look right: `format-kbd-macro` is like
`key-description`, i.e. it returns a human-readable version of a key
sequence. That is (more or less) the format understood by `kbd` (and
`key-parse`) but is not the format accepted by `key-binding`, which
expects an actual vector of events (which can degenerate to a string if
the events are simple enough).
Stefan
next parent reply other threads:[~2023-03-10 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167841008488.32504.7948735471580268728@vcs2.savannah.gnu.org>
[not found] ` <20230310010125.5A435C13A88@vcs2.savannah.gnu.org>
2023-03-10 19:40 ` Stefan Monnier [this message]
2023-03-10 19:43 ` [nongnu] elpa/meow 9860a7a218: Correct unused lexical variable (#411) Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7cvoe6t9.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=ideasman42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).