From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/meow 9860a7a218: Correct unused lexical variable (#411) Date: Fri, 10 Mar 2023 14:40:37 -0500 Message-ID: References: <167841008488.32504.7948735471580268728@vcs2.savannah.gnu.org> <20230310010125.5A435C13A88@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17910"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Campbell Barton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 10 20:41:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paicU-0004TU-Dw for ged-emacs-devel@m.gmane-mx.org; Fri, 10 Mar 2023 20:41:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paibl-0005Ct-K0; Fri, 10 Mar 2023 14:40:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paibj-0005CB-9k for emacs-devel@gnu.org; Fri, 10 Mar 2023 14:40:51 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paibf-0002Qs-Rh for emacs-devel@gnu.org; Fri, 10 Mar 2023 14:40:50 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A5AAF441D9E; Fri, 10 Mar 2023 14:40:45 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 55849441E27; Fri, 10 Mar 2023 14:40:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1678477244; bh=WnI2WgaabHX4NsJrwp3HGgGxcZo7VdnH99JCldaG1Zk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IMP4gEb62wPAgpzD0aahAq+SjnsDLE3FRWfXSlfE+s/IdjpoP7s8cqgswcvKyBp6X eKhIWU7YcveezXzRXbqv77sB4FRjHfDp/+Si/aAZnW2CERqq50VYtV7fb8btcbOl6V sy1dTHjsYM+YQ7PfU0SXPOlXf7T0GBgnB9tjQwKZnj9qRlUA3LcFTBEY2WZxN6NPrz xdwWtQgtwrrA9JS64i1VouH82Oyy+dO8r3IMDhfmQQJ4X9XrmWMstFforQEfWiFmuH 3hW2vxzBUbFXYp7M8aztk21c3fuyqvdJn9ceoxO8J91+j0w1IUPOU6n76T82U/g44J 4jfbUiP87NfkA== Original-Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3028A123267; Fri, 10 Mar 2023 14:40:44 -0500 (EST) In-Reply-To: <20230310010125.5A435C13A88@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Thu, 9 Mar 2023 20:01:25 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304255 Archived-At: > @@ -1636,7 +1636,7 @@ This command is a replacement for built-in `kmacro-end-macro'." > (interactive (list (help--read-key-sequence))) > (if (= 1 (length key-list)) > (let* ((key (format-kbd-macro (cdar key-list))) > - (cmd (key-binding (cdar key-list)))) > + (cmd (key-binding key))) Hmm... that doesn't look right: `format-kbd-macro` is like `key-description`, i.e. it returns a human-readable version of a key sequence. That is (more or less) the format understood by `kbd` (and `key-parse`) but is not the format accepted by `key-binding`, which expects an actual vector of events (which can degenerate to a string if the events are simple enough). Stefan