unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Problems with debug-on-entry in the Lisp debugger.
Date: Tue, 08 Mar 2005 13:59:22 -0500	[thread overview]
Message-ID: <jwv6502vuzc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87is42c8yp.fsf@xs4all.nl> (Lute Kamstra's message of "Tue, 08 Mar 2005 19:02:06 +0100")

> This gives a backtrace like this:

> ------ Buffer: *Backtrace* ------ 
> Debugger entered--entering a function:
> * (lambda (var) (if (or inhibit-debug-on-entry debugger-jumping-flag) nil (debug ...)) (list (quote setq) var (list ... var)))(x)
>   (inc x)
>   (progn (setq x 0) (inc x))
>   eval((progn (setq x 0) (inc x)))
>   eval-last-sexp-1(nil)
>   eval-last-sexp(nil)
>   call-interactively(eval-last-sexp)
> ------ Buffer: *Backtrace* ------ 

> where you can see the debug-entry-code (if (or inhibit-debug-on-entry
> debugger-jumping-flag) nil (debug ...)).  I would prefer to hide the
> internals of the debugger from its users.

debug.el already hides its internals.  See debugger-setup-buffer.
It just has to be updated to hide this part of the internals.

> You proposed to change defun, defsubst, defalias and defmacro to add
> debug-entry-code when their argument was in debug-function-list.  That
> is a similarly big change.

There's no need to do that.  The hooks are already present for defadvice, so
we should simply use them.  Better yet, we should use defadvice directly:

   (defadvice <FOO> (before debug-on-entry activate)
     (if inhibit-debug-on-entry nil (debug 'debug)))

This will properly survive function redefinitions.


        Stefan

  reply	other threads:[~2005-03-08 18:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-07 11:05 Problems with debug-on-entry in the Lisp debugger Lute Kamstra
2005-03-07 13:31 ` Stefan Monnier
2005-03-07 15:20   ` Lute Kamstra
2005-03-07 16:32     ` Stefan Monnier
2005-03-08 18:57       ` Lute Kamstra
2005-03-09 16:58         ` Richard Stallman
2005-03-09 17:30           ` Lute Kamstra
2005-03-07 13:40 ` Kim F. Storm
2005-03-07 14:20   ` drkm
2005-03-07 14:45     ` Kim F. Storm
2005-03-08  2:53 ` Richard Stallman
2005-03-08 18:02   ` Lute Kamstra
2005-03-08 18:59     ` Stefan Monnier [this message]
2005-03-09 10:14       ` Lute Kamstra
2005-03-09 16:58     ` Richard Stallman
2005-03-09 16:58     ` Richard Stallman
2005-03-09 17:38       ` Lute Kamstra
2005-03-10  0:26       ` Kevin Rodgers
2005-03-11  1:47         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv6502vuzc.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).