unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111086: gmm-utils.el (gmm-flet, gmm-labels): New macros.
Date: Tue, 04 Dec 2012 23:19:05 -0500	[thread overview]
Message-ID: <jwv624hqgii.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <b4mpq2pifkk.fsf@jpl.org> (Katsumi Yamaoka's message of "Wed, 05 Dec 2012 08:05:15 +0900")

> Defadvice?  Uhm, that defadvice code exists in an official source
> code is very ugly, I feel. :<

The problem with defadvice is that it overrides functions.  The letf
cases we're talking about also override functions, so they're just as
nasty as uses of defadvice.  Worse, they don't even announce themselves
in the docstring and they often remove themselves before you get
a chance to see that some overriding is going on.

So, yes, I much prefer defadvice.


        Stefan



  parent reply	other threads:[~2012-12-05  4:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1Tfocu-00056V-AU@vcs.savannah.gnu.org>
2012-12-04 18:52 ` [Emacs-diffs] /srv/bzr/emacs/trunk r111086: gmm-utils.el (gmm-flet, gmm-labels): New macros Stefan Monnier
2012-12-04 22:39   ` Katsumi Yamaoka
2012-12-04 23:05     ` Katsumi Yamaoka
2012-12-05  0:14       ` Katsumi Yamaoka
2012-12-05  2:26         ` Katsumi Yamaoka
2012-12-05  4:19       ` Stefan Monnier [this message]
2012-12-05  5:46         ` Katsumi Yamaoka
2012-12-05 19:29         ` Richard Stallman
2012-12-05 19:35           ` [Emacs-diffs] /srv/bzr/emacs/trunk r111086: gmm-utils.el(gmm-flet, " Drew Adams
2012-12-06  2:01           ` [Emacs-diffs] /srv/bzr/emacs/trunk r111086: gmm-utils.el (gmm-flet, " Katsumi Yamaoka
2012-12-06 13:27             ` Stefan Monnier
2012-12-06 22:46             ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv624hqgii.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).