From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111086: gmm-utils.el (gmm-flet, gmm-labels): New macros. Date: Tue, 04 Dec 2012 23:19:05 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354681161 11406 80.91.229.3 (5 Dec 2012 04:19:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Dec 2012 04:19:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: Katsumi Yamaoka Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 05 05:19:33 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tg6SC-0005n4-Fv for ged-emacs-devel@m.gmane.org; Wed, 05 Dec 2012 05:19:24 +0100 Original-Received: from localhost ([::1]:41502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg6S0-0004bM-8a for ged-emacs-devel@m.gmane.org; Tue, 04 Dec 2012 23:19:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg6Rv-0004b4-HW for emacs-devel@gnu.org; Tue, 04 Dec 2012 23:19:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tg6Ru-0000Hn-LS for emacs-devel@gnu.org; Tue, 04 Dec 2012 23:19:07 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:25441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg6Ru-0000Hj-Hn for emacs-devel@gnu.org; Tue, 04 Dec 2012 23:19:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09soXOY/2dsb2JhbABEtBGBCIIWAQVWIwULCzQSFBgNJIghugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="209104016" Original-Received: from 108-161-115-152.dsl.teksavvy.com (HELO pastel.home) ([108.161.115.152]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Dec 2012 23:19:06 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id ABAB158C73; Tue, 4 Dec 2012 23:19:05 -0500 (EST) In-Reply-To: (Katsumi Yamaoka's message of "Wed, 05 Dec 2012 08:05:15 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155282 Archived-At: > Defadvice? Uhm, that defadvice code exists in an official source > code is very ugly, I feel. :< The problem with defadvice is that it overrides functions. The letf cases we're talking about also override functions, so they're just as nasty as uses of defadvice. Worse, they don't even announce themselves in the docstring and they often remove themselves before you get a chance to see that some overriding is going on. So, yes, I much prefer defadvice. Stefan