From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: 'struct window' cleanup #4
Date: Mon, 02 Jul 2012 10:48:08 -0400 [thread overview]
Message-ID: <jwv4npqte53.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4FF17BAE.7090200@yandex.ru> (Dmitry Antipov's message of "Mon, 02 Jul 2012 14:45:02 +0400")
> Do we have a consensus about type(s) of 'window_end_vpos', 'vscroll',
> 'hscroll' and 'min_hscroll' fields of 'struct window'? Now I'm just
> assuming that ptrdiff_t is safer. Eli, please review if possible.
vscroll should be int, as should be the hscroll amounts.
The vpos probably as well. `ptrdiff' is for things like
buffer-positions (and it's only meaningful for the --with-wide-int
compilation option which I tend to consider as a waste of time).
Stefan
next prev parent reply other threads:[~2012-07-02 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:45 'struct window' cleanup #4 Dmitry Antipov
2012-07-02 14:48 ` Stefan Monnier [this message]
2012-07-02 17:07 ` Eli Zaretskii
2012-07-02 17:33 ` Eli Zaretskii
2012-07-03 5:54 ` 'struct window' cleanup #5 [Re: 'struct window' cleanup #4] Dmitry Antipov
2012-07-03 15:58 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4npqte53.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).