From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: 'struct window' cleanup #4 Date: Mon, 02 Jul 2012 10:48:08 -0400 Message-ID: References: <4FF17BAE.7090200@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1341240509 11238 80.91.229.3 (2 Jul 2012 14:48:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 2 Jul 2012 14:48:29 +0000 (UTC) Cc: Emacs development discussions To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 02 16:48:28 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SlhvO-00015C-BV for ged-emacs-devel@m.gmane.org; Mon, 02 Jul 2012 16:48:26 +0200 Original-Received: from localhost ([::1]:45534 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlhvN-0002xR-BL for ged-emacs-devel@m.gmane.org; Mon, 02 Jul 2012 10:48:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlhvH-0002ww-K4 for emacs-devel@gnu.org; Mon, 02 Jul 2012 10:48:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Slhv9-0002Ff-D7 for emacs-devel@gnu.org; Mon, 02 Jul 2012 10:48:19 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:35240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slhv9-0002Ev-8x for emacs-devel@gnu.org; Mon, 02 Jul 2012 10:48:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxKFY/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLDiYSFBgNJIgcBboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="192480914" Original-Received: from 69-196-161-88.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.88]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Jul 2012 10:48:09 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 9922B5976E; Mon, 2 Jul 2012 10:48:08 -0400 (EDT) In-Reply-To: <4FF17BAE.7090200@yandex.ru> (Dmitry Antipov's message of "Mon, 02 Jul 2012 14:45:02 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151352 Archived-At: > Do we have a consensus about type(s) of 'window_end_vpos', 'vscroll', > 'hscroll' and 'min_hscroll' fields of 'struct window'? Now I'm just > assuming that ptrdiff_t is safer. Eli, please review if possible. vscroll should be int, as should be the hscroll amounts. The vpos probably as well. `ptrdiff' is for things like buffer-positions (and it's only meaningful for the --with-wide-int compilation option which I tend to consider as a waste of time). Stefan