From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: project--completing-read-strict breaks ada-mode project completion table
Date: Thu, 17 Jan 2019 08:55:23 -0500 [thread overview]
Message-ID: <jwv4la7wgak.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: b4cce8f9-7eb9-380a-4802-06b2ab7744c4@yandex.ru
>> I can understand the motivation behind removing common prefixes, but the
>> proper way to do that is to implement a completion style and/or table
>> that does that, and make that style/table the default for projects.
> How exactly would you propose to do that?
His completion style relies on an advice to the completing-read code
which re-adds the text that was stripped during the completion.
Clearly, that won't work when used for completion-at-point.
I actually think his approach is interesting and maybe we should think
how our completion system could provide support for these kinds of
"styles".
>> The ada-mode completion style and table eliminates all directories from
>> the visible completion string, except the minimum needed to make the
>> string unique. I think this is a better solution to the problem;
>> project.el should allow the user to choose their prefered solution, by
>> choosing a completion style and table.
> The user is not choosing a table. The project backend does, and in your case
> it presents an entirely different look for file names from the other
> backends, with no way for the user to change it.
> I think that's bad.
Indeed, an important design constraint I followed for the completion
styles is that the user should be able to choose the style (hence the
indirection through completion-category-overrides).
I think part of Stephen's argument is that the same comment applies to
the new completion behavior of M-x project-find-file you installed
in 8f9d93f3054.
> Far be it from me to criticize the exact "uniquified" look for the entries,
> but I don't think it's a good place to produce them. If it's not possible to
> implement them via a completion style or something like that, that would
> apply to all project backends and their completion tables if the user so
> chooses, maybe it should just be a different command.
I'm not sure if it currently can work for any project backend, but its
design definitely aims for it to be backend-agnostic so it can be used
for any (flat) completion table (I don't think it'll work well with
completion-file-name-table).
Stefan
next prev parent reply other threads:[~2019-01-17 13:55 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180922154639.23195.66360@vcs0.savannah.gnu.org>
[not found] ` <20180922154640.9D58220310@vcs0.savannah.gnu.org>
2018-12-26 3:34 ` [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el Dmitry Gutov
2018-12-26 20:13 ` Stefan Monnier
2018-12-27 1:49 ` Dmitry Gutov
2018-12-27 14:39 ` Stefan Monnier
2018-12-28 3:45 ` Dmitry Gutov
2018-12-31 11:42 ` Dmitry Gutov
2018-12-31 15:12 ` Eli Zaretskii
2019-01-02 23:47 ` Dmitry Gutov
2019-01-02 1:49 ` Stefan Monnier
2019-01-03 0:41 ` Dmitry Gutov
2019-01-02 21:53 ` Juri Linkov
2019-01-02 23:02 ` Dmitry Gutov
2019-01-03 0:37 ` Juri Linkov
2019-01-03 11:45 ` Dmitry Gutov
2019-01-03 20:53 ` Juri Linkov
2019-01-06 1:22 ` Dmitry Gutov
2019-01-07 23:22 ` Dmitry Gutov
2019-01-07 23:27 ` Dmitry Gutov
2019-01-08 14:21 ` Michael Albinus
2019-01-08 23:06 ` Dmitry Gutov
2019-01-09 8:10 ` Michael Albinus
2019-01-09 15:24 ` Dmitry Gutov
2019-01-09 14:57 ` Dmitry Gutov
2019-01-09 23:15 ` Juri Linkov
2019-01-10 10:20 ` Dmitry Gutov
2019-01-10 21:41 ` Juri Linkov
2019-01-12 1:48 ` Dmitry Gutov
2019-01-18 3:52 ` Dmitry Gutov
2019-01-18 12:49 ` Stefan Monnier
2019-01-18 19:28 ` Dmitry Gutov
2019-01-18 21:11 ` Stefan Monnier
2019-01-18 22:53 ` Dmitry Gutov
2018-12-29 0:27 ` Dmitry Gutov
2018-12-29 17:09 ` Dmitry Gutov
2018-12-29 21:54 ` Juri Linkov
2018-12-30 23:06 ` Dmitry Gutov
2019-01-02 1:48 ` Stefan Monnier
2019-01-02 22:05 ` Juri Linkov
2019-01-03 3:44 ` Stefan Monnier
2019-01-03 20:45 ` Juri Linkov
2019-01-12 1:10 ` Making project-files the "canonical" generic, was: " Dmitry Gutov
2019-01-12 18:53 ` Making project-files the "canonical" generic Stephen Leake
2019-01-13 0:54 ` Dmitry Gutov
2019-01-15 1:14 ` Stephen Leake
2019-01-16 16:38 ` Stefan Monnier
2019-01-17 2:23 ` Dmitry Gutov
2019-01-17 13:25 ` Stefan Monnier
2019-01-18 1:00 ` Dmitry Gutov
2019-01-16 19:02 ` project--completing-read-strict breaks ada-mode project completion table Stephen Leake
2019-01-16 22:02 ` Stephen Leake
2019-01-17 23:17 ` Stephen Leake
2019-01-18 2:04 ` Dmitry Gutov
2019-01-19 3:35 ` Stephen Leake
2019-01-19 22:05 ` Dmitry Gutov
2019-01-20 19:34 ` Stephen Leake
2019-01-17 2:21 ` Dmitry Gutov
2019-01-17 13:55 ` Stefan Monnier [this message]
2019-01-17 21:35 ` John Yates
2019-01-18 2:19 ` Dmitry Gutov
2019-01-18 3:05 ` Stefan Monnier
2019-01-19 0:26 ` Dmitry Gutov
2019-01-21 19:32 ` Stephen Leake
2019-01-22 0:09 ` Dmitry Gutov
2019-02-07 1:20 ` Stephen Leake
2019-02-11 21:50 ` Stefan Monnier
2019-02-12 1:31 ` Stephen Leake
2019-02-15 15:50 ` Stephen Leake
2019-02-15 22:47 ` Stephen Leake
2019-02-15 23:38 ` Stephen Leake
2019-04-19 17:49 ` Stephen Leake
2019-05-03 0:48 ` Dmitry Gutov
2019-05-04 10:39 ` Stephen Leake
2019-05-07 18:02 ` Stephen Leake
2019-05-07 22:35 ` Dmitry Gutov
2019-05-08 1:53 ` Stefan Monnier
2019-05-14 2:14 ` Dmitry Gutov
2019-05-14 2:13 ` Dmitry Gutov
2019-02-19 17:45 ` Stefan Monnier
2019-02-20 19:58 ` Stephen Leake
2019-02-21 2:00 ` Stefan Monnier
2019-01-21 19:36 ` Stephen Leake
2019-01-22 0:20 ` Dmitry Gutov
2019-01-17 3:04 ` Making project-files the "canonical" generic Dmitry Gutov
2018-12-27 20:33 ` [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el Juri Linkov
2018-12-27 23:31 ` Dmitry Gutov
2018-12-27 23:45 ` Juri Linkov
2018-12-28 6:04 ` Dmitry Gutov
2018-12-28 18:07 ` Stefan Monnier
2018-12-29 0:31 ` Dmitry Gutov
2018-12-29 22:02 ` Juri Linkov
2018-12-30 23:13 ` Dmitry Gutov
2019-01-02 22:11 ` Juri Linkov
2019-01-02 23:23 ` Dmitry Gutov
2019-01-03 0:44 ` Juri Linkov
2019-01-03 11:52 ` Dmitry Gutov
2019-01-03 15:35 ` Stefan Monnier
2019-01-03 23:06 ` Dmitry Gutov
2019-02-07 12:23 ` Dmitry Gutov
2019-02-07 13:05 ` Stefan Monnier
2019-02-14 1:11 ` Dmitry Gutov
2019-01-03 20:57 ` Juri Linkov
2019-01-03 23:21 ` Dmitry Gutov
2019-01-05 22:12 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4la7wgak.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).