From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: project--completing-read-strict breaks ada-mode project completion table
Date: Mon, 11 Feb 2019 16:50:09 -0500 [thread overview]
Message-ID: <jwv4l9aowp0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 86lg2swg14.fsf@stephe-leake.org
>>> And again, it doesn't have to be a separate command, the behavior
>>> could be customizable and dispatched inside the one command's
>>> implementation.
> I've now implemented this.
> Gnu ELPA has updated versions of path-iterator and uniquified-files.
> I added a new file completion style; file-root-rel, in
> uniquified-files/file-complete-root-relative.el.
>
> Attached is an elisp file demo-project-file-completion.el, which
> rewrites project--completing-read-strict to allow either the user or the
> project backend to specify the completion style, and provides examples
> of each of three styles:
[...]
> (table-styles (cdr (assq 'styles (completion-metadata "" collection nil))))
> (completion-category-overrides
> (list (list 'project-file (cons 'styles
> (or table-styles
> project-file-completion-styles)))))
>
> ;; If the completion table is a list, or a function that does
> ;; not return styles metadata, we set completion-styles to
> ;; reflect the user choice.
> (completion-styles (if table-styles nil project-file-completion-styles))
This gives precedence to the collection's styles with no way for the
user to override this choice. This problem is the reason why I designed
the current system to go through the indirection of a category, making
it possible for the user to override the category's default styles via
completion-category-overrides.
> The uniquify-file completion style works on a list of files; see the
[...]
> However, file-root-rel does not, because the root directory must be
> stored somewhere that is accessible from the completion code.
I don't understand this. Why can't the completion style compute the
common-prefix?
> uniquify-files.el now adds two functions to completion-styles-alist, for
> converting strings from user to table input format, or user to data
> format.
As I mentioned in another message to João, I think we should move from
completion-style-alist to using generic functions that dispatch on the style.
Also, I don't quite understand why we need 2: they both seem to
implement the same direction of the conversion (i.e. from "user-string"
to "data-string"). I see that uniq-file-get-data-string does more
(i.e. it tries to find the corresponding match if there's only one) but
I don't understand why you need to do that: this seems to do a kind of
completion which minibuffer-complete-and-exit should already have done
(if `require-match` is set) or which shouldn't be done (if
`require-match` is not set).
> Together with the advice on completing-read-default and
> test-completion, this could be moved to minibuffer.el.
As you mention in uniquify-files.el:
(defun completion-get-data-string (user-string table pred)
[...]
;; FIXME: This is ultimately called from
;; `completion-try-completion' or `completion-all-completions';
;; there is only one style currently being used. Need to pass that
;; style from there to here.
it only makes sense to call the conversion function corresponding to the
style that was used to generate that string.
[ Also while a specific call to minibuffer-complete (or
minibuffer-completion-help, or minibuffer-force-complete, ...) only
uses a single style, a given completing-read session can currently use
several completion styles. ]
So I think we should fix this FIXME before we can move this code to
minibuffer.el. Maybe we can save the completion style that returned
that string in a text-property, or even directly store the conversion
function in there (so we don't need to extend completion-style-alist).
Stefan
next prev parent reply other threads:[~2019-02-11 21:50 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180922154639.23195.66360@vcs0.savannah.gnu.org>
[not found] ` <20180922154640.9D58220310@vcs0.savannah.gnu.org>
2018-12-26 3:34 ` [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el Dmitry Gutov
2018-12-26 20:13 ` Stefan Monnier
2018-12-27 1:49 ` Dmitry Gutov
2018-12-27 14:39 ` Stefan Monnier
2018-12-28 3:45 ` Dmitry Gutov
2018-12-31 11:42 ` Dmitry Gutov
2018-12-31 15:12 ` Eli Zaretskii
2019-01-02 23:47 ` Dmitry Gutov
2019-01-02 1:49 ` Stefan Monnier
2019-01-03 0:41 ` Dmitry Gutov
2019-01-02 21:53 ` Juri Linkov
2019-01-02 23:02 ` Dmitry Gutov
2019-01-03 0:37 ` Juri Linkov
2019-01-03 11:45 ` Dmitry Gutov
2019-01-03 20:53 ` Juri Linkov
2019-01-06 1:22 ` Dmitry Gutov
2019-01-07 23:22 ` Dmitry Gutov
2019-01-07 23:27 ` Dmitry Gutov
2019-01-08 14:21 ` Michael Albinus
2019-01-08 23:06 ` Dmitry Gutov
2019-01-09 8:10 ` Michael Albinus
2019-01-09 15:24 ` Dmitry Gutov
2019-01-09 14:57 ` Dmitry Gutov
2019-01-09 23:15 ` Juri Linkov
2019-01-10 10:20 ` Dmitry Gutov
2019-01-10 21:41 ` Juri Linkov
2019-01-12 1:48 ` Dmitry Gutov
2019-01-18 3:52 ` Dmitry Gutov
2019-01-18 12:49 ` Stefan Monnier
2019-01-18 19:28 ` Dmitry Gutov
2019-01-18 21:11 ` Stefan Monnier
2019-01-18 22:53 ` Dmitry Gutov
2018-12-29 0:27 ` Dmitry Gutov
2018-12-29 17:09 ` Dmitry Gutov
2018-12-29 21:54 ` Juri Linkov
2018-12-30 23:06 ` Dmitry Gutov
2019-01-02 1:48 ` Stefan Monnier
2019-01-02 22:05 ` Juri Linkov
2019-01-03 3:44 ` Stefan Monnier
2019-01-03 20:45 ` Juri Linkov
2019-01-12 1:10 ` Making project-files the "canonical" generic, was: " Dmitry Gutov
2019-01-12 18:53 ` Making project-files the "canonical" generic Stephen Leake
2019-01-13 0:54 ` Dmitry Gutov
2019-01-15 1:14 ` Stephen Leake
2019-01-16 16:38 ` Stefan Monnier
2019-01-17 2:23 ` Dmitry Gutov
2019-01-17 13:25 ` Stefan Monnier
2019-01-18 1:00 ` Dmitry Gutov
2019-01-16 19:02 ` project--completing-read-strict breaks ada-mode project completion table Stephen Leake
2019-01-16 22:02 ` Stephen Leake
2019-01-17 23:17 ` Stephen Leake
2019-01-18 2:04 ` Dmitry Gutov
2019-01-19 3:35 ` Stephen Leake
2019-01-19 22:05 ` Dmitry Gutov
2019-01-20 19:34 ` Stephen Leake
2019-01-17 2:21 ` Dmitry Gutov
2019-01-17 13:55 ` Stefan Monnier
2019-01-17 21:35 ` John Yates
2019-01-18 2:19 ` Dmitry Gutov
2019-01-18 3:05 ` Stefan Monnier
2019-01-19 0:26 ` Dmitry Gutov
2019-01-21 19:32 ` Stephen Leake
2019-01-22 0:09 ` Dmitry Gutov
2019-02-07 1:20 ` Stephen Leake
2019-02-11 21:50 ` Stefan Monnier [this message]
2019-02-12 1:31 ` Stephen Leake
2019-02-15 15:50 ` Stephen Leake
2019-02-15 22:47 ` Stephen Leake
2019-02-15 23:38 ` Stephen Leake
2019-04-19 17:49 ` Stephen Leake
2019-05-03 0:48 ` Dmitry Gutov
2019-05-04 10:39 ` Stephen Leake
2019-05-07 18:02 ` Stephen Leake
2019-05-07 22:35 ` Dmitry Gutov
2019-05-08 1:53 ` Stefan Monnier
2019-05-14 2:14 ` Dmitry Gutov
2019-05-14 2:13 ` Dmitry Gutov
2019-02-19 17:45 ` Stefan Monnier
2019-02-20 19:58 ` Stephen Leake
2019-02-21 2:00 ` Stefan Monnier
2019-01-21 19:36 ` Stephen Leake
2019-01-22 0:20 ` Dmitry Gutov
2019-01-17 3:04 ` Making project-files the "canonical" generic Dmitry Gutov
2018-12-27 20:33 ` [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el Juri Linkov
2018-12-27 23:31 ` Dmitry Gutov
2018-12-27 23:45 ` Juri Linkov
2018-12-28 6:04 ` Dmitry Gutov
2018-12-28 18:07 ` Stefan Monnier
2018-12-29 0:31 ` Dmitry Gutov
2018-12-29 22:02 ` Juri Linkov
2018-12-30 23:13 ` Dmitry Gutov
2019-01-02 22:11 ` Juri Linkov
2019-01-02 23:23 ` Dmitry Gutov
2019-01-03 0:44 ` Juri Linkov
2019-01-03 11:52 ` Dmitry Gutov
2019-01-03 15:35 ` Stefan Monnier
2019-01-03 23:06 ` Dmitry Gutov
2019-02-07 12:23 ` Dmitry Gutov
2019-02-07 13:05 ` Stefan Monnier
2019-02-14 1:11 ` Dmitry Gutov
2019-01-03 20:57 ` Juri Linkov
2019-01-03 23:21 ` Dmitry Gutov
2019-01-05 22:12 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4l9aowp0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).