unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: bob@rattlesnake.com, emacs-devel@gnu.org, miles@gnu.org
Subject: Re: +face-remapping-20040505-0.patch
Date: 09 May 2004 20:17:04 -0400	[thread overview]
Message-ID: <jwv3c6987yc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1BMyDz-0001Hg-6Q@fencepost.gnu.org>

>     I still think that face-remapping should rely on face-inheritance rather
>     than allow mapping a face to several (merged) faces.
> I am not quite sure what change you are proposing.
> If you are saying that the feature of remapping X to (Y Z)
> should be removed, and instead the user should have to
> define W as (Y Z) then remap X to W, I think that is
> a loss of convenience with nearly zero gain in simplicity.

Well, maybe it doesn't make the code simpler, I don't know.
But it does simplify the explanation of what (face-attribute X :foo)
returns (since we've already dealt with the issue of whether it returns the
info corresponding to Y or to Y+Z or to Y+Z+default).

Also the added convenience of not having to define W might not be
that great.  After all, I expect 99% of the remapping to just be from
X to Y.  Also the intermediate W might/should be added anyway just to make
easier for the user to customize the resulting face.

Maybe it doesn't make the current implementation simple, but it at least
makes the concept simpler.  OTOH, that's assuming that "99% of the remapping
[will] just be from X to Y".  This 99% assumption assumes that mapping X
to (X Y) doesn't work, tho.

OTOH, I must say that the most important use of this remapping facility
would be to tweak faces in various modes, so mapping X to (X Y) would be
the most useful application, if not the only one.  So maybe we should
have face-addition-alist rather face-remapping-alist so we could just put
(region . bold) in order to add bold to the region face.


        Stefan

  reply	other threads:[~2004-05-10  0:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-04 15:44 +face-remapping-20040505-0.patch Miles Bader
2004-05-05 20:20 ` +face-remapping-20040505-0.patch Richard Stallman
2004-05-05 22:12   ` +face-remapping-20040505-0.patch Miles Bader
2004-05-06 14:05     ` +face-remapping-20040505-0.patch Stefan Monnier
2004-05-08  1:20       ` +face-remapping-20040505-0.patch Richard Stallman
2004-05-08  1:39         ` +face-remapping-20040505-0.patch Miles Bader
2004-05-09 10:38           ` +face-remapping-20040505-0.patch Richard Stallman
2004-05-09 16:42             ` +face-remapping-20040505-0.patch Stefan Monnier
2004-05-10  0:00               ` +face-remapping-20040505-0.patch Richard Stallman
2004-05-10  0:17                 ` Stefan Monnier [this message]
2004-05-10 17:54                   ` +face-remapping-20040505-0.patch Richard Stallman
2004-05-10 18:25                     ` +face-remapping-20040505-0.patch Stefan Monnier
2004-05-10 22:33                       ` +face-remapping-20040505-0.patch Miles Bader
2004-05-10 23:08                         ` +face-remapping-20040505-0.patch Stefan Monnier
2004-05-11  4:47                           ` +face-remapping-20040505-0.patch Miles Bader
2004-05-11 16:30                           ` +face-remapping-20040505-0.patch Kevin Rodgers
2004-05-12  1:30                             ` +face-remapping-20040505-0.patch Miles Bader
2004-05-10  0:42             ` +face-remapping-20040505-0.patch Miles Bader
2004-05-10 17:54               ` +face-remapping-20040505-0.patch Richard Stallman
2004-05-13 21:28                 ` +face-remapping-20040505-0.patch Miles Bader
2004-05-24  8:04                   ` +face-remapping-20040505-0.patch Kim F. Storm
2004-05-24  8:15 ` +face-remapping-20040505-0.patch Kim F. Storm
2004-05-24  8:48   ` +face-remapping-20040505-0.patch Miles Bader
2004-05-24 10:03     ` +face-remapping-20040505-0.patch Kim F. Storm
2004-05-24 10:24       ` +face-remapping-20040505-0.patch David Kastrup
2004-05-24 17:35         ` +face-remapping-20040505-0.patch Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv3c6987yc.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=bob@rattlesnake.com \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).