From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andrea Corallo <akrl@sdf.org>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/elisp-benchmarks 8a8e9fa6a8: Make it usable on Emacs-27
Date: Thu, 10 Feb 2022 08:55:39 -0500 [thread overview]
Message-ID: <jwv35kqvngh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <xjfee4bt8nz.fsf@ma.sdf.org> (Andrea Corallo's message of "Thu, 10 Feb 2022 08:42:08 +0000")
>> (let ((tests (let ((names '()))
>> (mapatoms (lambda (s)
>> (let ((name (symbol-name s)))
>> - (when (string-match
>> - "\\`elb-\\(.*\\)-entry\\'" name)
>> + (when (and (fboundp s)
>> + (string-match
>> + "\\`elb-\\(.*\\)-entry\\'" name))
>> (push (match-string 1 name) names)))))
>
> Ah okay I see now. Your previous changeset is fixed here changing the
> semantic of `elisp-benchmarks-run'.
Not that the only change here is the use of `fboundp` to make sure we
don't try to run `elb-foo-entry` just because there's a symbol by that
name in the obarray.
> This change (as others) has really nothing to do with "Make it usable on
> Emacs-27".
It does: in Emacs-27, the function `elb-pack-unpack-entry` ends up not
being defined, but it somehow does end up interned in `obarray`.
Stefan
prev parent reply other threads:[~2022-02-10 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164433519015.9248.5471973426006203013@vcs2.savannah.gnu.org>
[not found] ` <20220208154631.0867BC0DA37@vcs2.savannah.gnu.org>
2022-02-10 8:42 ` [elpa] externals/elisp-benchmarks 8a8e9fa6a8: Make it usable on Emacs-27 Andrea Corallo
2022-02-10 13:55 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv35kqvngh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).