From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/elisp-benchmarks 8a8e9fa6a8: Make it usable on Emacs-27 Date: Thu, 10 Feb 2022 08:55:39 -0500 Message-ID: References: <164433519015.9248.5471973426006203013@vcs2.savannah.gnu.org> <20220208154631.0867BC0DA37@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17034"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 10 17:39:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nICU5-0004Eg-0l for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Feb 2022 17:39:53 +0100 Original-Received: from localhost ([::1]:51446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nICU3-00044c-NY for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Feb 2022 11:39:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nI9vG-0005oY-FL for emacs-devel@gnu.org; Thu, 10 Feb 2022 08:55:46 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:5036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nI9vD-0003aS-Eo for emacs-devel@gnu.org; Thu, 10 Feb 2022 08:55:45 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0A05D1002B9; Thu, 10 Feb 2022 08:55:42 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1DA0A100129; Thu, 10 Feb 2022 08:55:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1644501341; bh=s7Loe21e577b3O1kTXwQ6diX+v/YYxvukaA9M2d7R18=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LcKFdZxlavLhtgL54axk84CoXx5S0suVLWLBhmAqTIqJNoS+De58T8qZWkmzStpgg Goa2JkcV2rpYjXG1weddtBQIfyIOSSzs7aGj4ke9IrPR0dD5kAoei1NGFZh3sAT38M ocivFl8LkhdWMMPkZGKoVSmRm5fE2Qv6sbhRQ95mvZ83YvLuMN7Ul1tOG39Imjh+Rk 963/zFcD3E4jCNBpiOI6OjPz8eTGZMrQGgj0CVUlb0dOs7Q0b2TMlpsskOT7MZdSI5 83KEf1WIBA2QEsSaT3YjrO8Jjkf8xLsT9Bg7KPq5QLW2N6iapMcimnRDohvvETT4jp F957/QKZ0q+SQ== Original-Received: from pastel (76-10-138-212.dsl.teksavvy.com [76.10.138.212]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E41EE1203E4; Thu, 10 Feb 2022 08:55:40 -0500 (EST) In-Reply-To: (Andrea Corallo's message of "Thu, 10 Feb 2022 08:42:08 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286142 Archived-At: >> (let ((tests (let ((names '())) >> (mapatoms (lambda (s) >> (let ((name (symbol-name s))) >> - (when (string-match >> - "\\`elb-\\(.*\\)-entry\\'" name) >> + (when (and (fboundp s) >> + (string-match >> + "\\`elb-\\(.*\\)-entry\\'" name)) >> (push (match-string 1 name) names))))) > > Ah okay I see now. Your previous changeset is fixed here changing the > semantic of `elisp-benchmarks-run'. Not that the only change here is the use of `fboundp` to make sure we don't try to run `elb-foo-entry` just because there's a symbol by that name in the obarray. > This change (as others) has really nothing to do with "Make it usable on > Emacs-27". It does: in Emacs-27, the function `elb-pack-unpack-entry` ends up not being defined, but it somehow does end up interned in `obarray`. Stefan