unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org, Andreas Schwab <schwab@linux-m68k.org>,
	Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: Re: Emacs-24.3 crash when browse-url
Date: Tue, 04 Dec 2012 16:21:56 -0500	[thread overview]
Message-ID: <jwv1uf5tsyd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878v9d5zln.fsf@gmail.com> (Thierry Volpiatto's message of "Tue,  04 Dec 2012 21:31:00 +0100")

Paul, can you take a look at this?

>>>>> Debugger entered--Lisp error: (error "binding stack not balanced (serious byte compiler bug)")
>>>>> browse-url-xdg-open("http://www.google.fr" nil)
>>>> M-x disassemble RET browse-url-xdg-open RET
>>> --8<---------------cut here---------------start------------->8---
>>> byte code for browse-url-xdg-open:
>>> doc:  Pass the specified URL to the "xdg-open" command. ...
>>> args: (url &optional ignored)
>>> interactive: (browse-url-interactive-arg "URL: ")
>>> 0	constant  call-process
>>> 1	constant  "xdg-open"
>>> 2	constant  nil
>>> 3	constant  0
>>> 4	constant  nil
>>> 5	varref	  url
>>> 6	call	  5
>>> 7	return	  
>>> --8<---------------cut here---------------end--------------->8---
>> 
>> Hmm... "binding stack not balanced (serious byte compiler bug)" means
>> that the specpdl stack (the stack of things that need to be unwound,
>> such as unwind-protects and dynamic let bindings) does not have the same
>> height at the end of (presumably) browse-url-xdg-open as it had at
>> the beginning.  But as we see above, browse-url-xdg-open does not push
>> nor pop anything to/from that stack (it does push constants onto the
>> bytecode's execution stack, but that's a completely different stack).
> Thanks for explanation.

My pleasure.

>> So, the specpdl stack was somehow messed up, presumably during the
>> execution of browse-url-xdg-open but apparently not by the byte code of
>> browse-url-xdg-open.  It could be a problem in `call-process'.
> Ok, here the last working revision:
> --8<---------------cut here---------------start------------->8---
> changeset:   123952:4d87702c495a
> user:        Paul Eggert <eggert@cs.ucla.edu>
> date:        Mon Dec 03 13:07:47 2012 -0800
> summary:     * bytecode.c, lisp.h (Qbytecode): Remove.
> --8<---------------cut here---------------end--------------->8---
> And the crash reappear when I compile from here:
> --8<---------------cut here---------------start------------->8---
> changeset:   123953:342630a53fea
> user:        Paul Eggert <eggert@cs.ucla.edu>
> date:        Mon Dec 03 13:42:12 2012 -0800
> summary:     Don't let call-process be a zombie factory.
> --8<---------------cut here---------------end--------------->8---

Aha!


        Stefan



  parent reply	other threads:[~2012-12-04 21:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 13:26 Emacs-24.3 crash when browse-url Thierry Volpiatto
2012-12-04 13:40 ` Andreas Schwab
2012-12-04 14:29   ` Thierry Volpiatto
2012-12-04 14:57   ` Thierry Volpiatto
2012-12-04 15:01     ` Andreas Schwab
2012-12-04 15:13       ` Thierry Volpiatto
2012-12-04 16:16         ` Andreas Schwab
2012-12-04 16:40           ` Thierry Volpiatto
2012-12-04 17:21             ` Stefan Monnier
2012-12-04 18:01               ` Thierry Volpiatto
2012-12-04 18:45                 ` Stefan Monnier
2012-12-04 20:31                   ` Thierry Volpiatto
2012-12-04 21:19                     ` Andreas Schwab
2012-12-05 19:44                       ` Thierry Volpiatto
2012-12-04 21:21                     ` Stefan Monnier [this message]
2012-12-05 10:23                       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1uf5tsyd.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=schwab@linux-m68k.org \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).