From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Emacs-24.3 crash when browse-url Date: Tue, 04 Dec 2012 16:21:56 -0500 Message-ID: References: <87mwxuhrso.fsf@gmail.com> <87y5hd6f23.fsf@gmail.com> <87pq2p6ebj.fsf@gmail.com> <87lidd6aam.fsf@gmail.com> <87hao166im.fsf@gmail.com> <878v9d5zln.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354656128 17198 80.91.229.3 (4 Dec 2012 21:22:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Dec 2012 21:22:08 +0000 (UTC) Cc: emacs-devel@gnu.org, Andreas Schwab , Thierry Volpiatto To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 04 22:22:20 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TfzwY-0001Xe-3E for ged-emacs-devel@m.gmane.org; Tue, 04 Dec 2012 22:22:18 +0100 Original-Received: from localhost ([::1]:60574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfzwL-0007vr-VI for ged-emacs-devel@m.gmane.org; Tue, 04 Dec 2012 16:22:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfzwJ-0007vj-LX for emacs-devel@gnu.org; Tue, 04 Dec 2012 16:22:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfzwD-0001Ns-Qu for emacs-devel@gnu.org; Tue, 04 Dec 2012 16:22:03 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:59417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfzwD-0001Nb-O7 for emacs-devel@gnu.org; Tue, 04 Dec 2012 16:21:57 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09soXOY/2dsb2JhbABEDrQDgQiCFQEBBAEnLw8UEAs0EhQYDSQTiAkFugmLCIU8A4hCmnGBWIIwVw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="209084291" Original-Received: from 108-161-115-152.dsl.teksavvy.com (HELO pastel.home) ([108.161.115.152]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Dec 2012 16:21:56 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 78AD458C73; Tue, 4 Dec 2012 16:21:56 -0500 (EST) In-Reply-To: <878v9d5zln.fsf@gmail.com> (Thierry Volpiatto's message of "Tue, 04 Dec 2012 21:31:00 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155264 Archived-At: Paul, can you take a look at this? >>>>> Debugger entered--Lisp error: (error "binding stack not balanced (serious byte compiler bug)") >>>>> browse-url-xdg-open("http://www.google.fr" nil) >>>> M-x disassemble RET browse-url-xdg-open RET >>> --8<---------------cut here---------------start------------->8--- >>> byte code for browse-url-xdg-open: >>> doc: Pass the specified URL to the "xdg-open" command. ... >>> args: (url &optional ignored) >>> interactive: (browse-url-interactive-arg "URL: ") >>> 0 constant call-process >>> 1 constant "xdg-open" >>> 2 constant nil >>> 3 constant 0 >>> 4 constant nil >>> 5 varref url >>> 6 call 5 >>> 7 return >>> --8<---------------cut here---------------end--------------->8--- >> >> Hmm... "binding stack not balanced (serious byte compiler bug)" means >> that the specpdl stack (the stack of things that need to be unwound, >> such as unwind-protects and dynamic let bindings) does not have the same >> height at the end of (presumably) browse-url-xdg-open as it had at >> the beginning. But as we see above, browse-url-xdg-open does not push >> nor pop anything to/from that stack (it does push constants onto the >> bytecode's execution stack, but that's a completely different stack). > Thanks for explanation. My pleasure. >> So, the specpdl stack was somehow messed up, presumably during the >> execution of browse-url-xdg-open but apparently not by the byte code of >> browse-url-xdg-open. It could be a problem in `call-process'. > Ok, here the last working revision: > --8<---------------cut here---------------start------------->8--- > changeset: 123952:4d87702c495a > user: Paul Eggert > date: Mon Dec 03 13:07:47 2012 -0800 > summary: * bytecode.c, lisp.h (Qbytecode): Remove. > --8<---------------cut here---------------end--------------->8--- > And the crash reappear when I compile from here: > --8<---------------cut here---------------start------------->8--- > changeset: 123953:342630a53fea > user: Paul Eggert > date: Mon Dec 03 13:42:12 2012 -0800 > summary: Don't let call-process be a zombie factory. > --8<---------------cut here---------------end--------------->8--- Aha! Stefan