From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Michael Albinus <michael.albinus@gmx.de>,
emacs-devel@gnu.org
Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063)
Date: Fri, 26 Mar 2021 12:32:32 -0400 [thread overview]
Message-ID: <jwv1rc16fpd.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878s6aaq0x.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 26 Mar 2021 15:33:18 +0000")
>>> What's the performance impact here? This is going to be called a whole
>>> bunch of times when the user hits TAB...
>> It should be OK to do the condition-case wrapping around the loop rather
>> than within it, so the performance impact should be negligible.
> "Around the loop" means "around completing-read",
Not necessarily, e.g.
Stefan
diff --git a/lisp/simple.el b/lisp/simple.el
index 959bd83117..91069aa02a 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1982,7 +1982,8 @@ read-extended-command
(concat (cond
((eq current-prefix-arg '-) "- ")
((and (consp current-prefix-arg)
- (eq (car current-prefix-arg) 4)) "C-u ")
+ (eq (car current-prefix-arg) 4))
+ "C-u ")
((and (consp current-prefix-arg)
(integerp (car current-prefix-arg)))
(format "%d " (car current-prefix-arg)))
@@ -1998,11 +1999,12 @@ read-extended-command
"M-X "
"M-x "))
(lambda (string pred action)
- (if (and suggest-key-bindings (eq action 'metadata))
- '(metadata
- (affixation-function . read-extended-command--affixation)
- (category . command))
- (complete-with-action action obarray string pred)))
+ (with-demoted-errors "Completion error: %S"
+ (if (and suggest-key-bindings (eq action 'metadata))
+ '(metadata
+ (affixation-function . read-extended-command--affixation)
+ (category . command))
+ (complete-with-action action obarray string pred))))
(lambda (sym)
(and (commandp sym)
(or (null read-extended-command-predicate)
next prev parent reply other threads:[~2021-03-26 16:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210313133546.6042.78482@vcs0.savannah.gnu.org>
[not found] ` <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org>
2021-03-13 22:27 ` master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Basil L. Contovounesios
2021-03-13 23:20 ` Stefan Monnier
2021-03-14 8:39 ` Michael Albinus
2021-03-14 12:59 ` Basil L. Contovounesios
2021-03-14 14:57 ` Stefan Monnier
2021-03-24 22:19 ` Basil L. Contovounesios
2021-03-25 8:25 ` Michael Albinus
2021-03-26 15:18 ` Basil L. Contovounesios
2021-03-26 15:24 ` Michael Albinus
2021-03-25 9:12 ` Lars Ingebrigtsen
2021-03-25 14:05 ` Stefan Monnier
2021-03-26 11:28 ` Lars Ingebrigtsen
2021-03-26 13:39 ` Stefan Monnier
2021-03-26 14:42 ` Michael Albinus
2021-03-26 18:39 ` Basil L. Contovounesios
2021-03-26 15:36 ` Basil L. Contovounesios
2021-03-26 16:37 ` Stefan Monnier
2021-03-26 18:18 ` Basil L. Contovounesios
2021-03-26 22:12 ` Lars Ingebrigtsen
2021-03-26 15:57 ` Basil L. Contovounesios
2021-03-26 15:33 ` Basil L. Contovounesios
2021-03-26 16:32 ` Stefan Monnier [this message]
2021-03-26 18:18 ` Basil L. Contovounesios
2021-03-26 15:27 ` Basil L. Contovounesios
2021-03-26 22:11 ` Lars Ingebrigtsen
2021-03-27 1:18 ` Basil L. Contovounesios
2021-03-27 12:33 ` Lars Ingebrigtsen
2021-03-27 20:29 ` Basil L. Contovounesios
2021-03-14 14:57 ` Stefan Monnier
2021-03-14 18:42 ` Michael Albinus
2021-03-14 20:30 ` Stefan Monnier
2021-03-15 9:00 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1rc16fpd.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).