From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Fri, 26 Mar 2021 12:32:32 -0400 Message-ID: References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> <87sg4ygmd9.fsf@gmx.de> <87zgz5uc0k.fsf@tcd.ie> <87tup0kxeg.fsf@tcd.ie> <878s6ba96u.fsf@gnus.org> <878s6aaq0x.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40098"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Michael Albinus , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 26 17:34:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPpPn-000AJm-Ny for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 17:34:27 +0100 Original-Received: from localhost ([::1]:37610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPpPm-00086b-NY for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Mar 2021 12:34:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPpO3-0006hg-D6 for emacs-devel@gnu.org; Fri, 26 Mar 2021 12:32:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPpO0-0001hq-Gl for emacs-devel@gnu.org; Fri, 26 Mar 2021 12:32:38 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6A5B4809CB; Fri, 26 Mar 2021 12:32:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1BD2F80182; Fri, 26 Mar 2021 12:32:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1616776353; bh=kBPTJ6xYQoA17dRGLDdXD53QukvR3wFQMb9IDfBRu5w=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GaFg3d+KfAUywh8B80h6qcSiLU7NJnAphhVj+H+8oOfGGpjpDkgZSQBhkcSN7hw30 OjMNabKlN2dtpGqVMsHVX7hvBStXOPYxXSp0hyMTwDF25vueeSzI0tok2btru+mdsj JloOeJZvC3i9eYotx1XPuSMWMZrSSjYwbvlM8xMjX1x2qE0fkMkmkg72hIx10JMUyQ 76iSl9tAbtrddKtjAhqOkDeTVyS6vPAQikYgIj2f9lQWUt7Esnv7Vf3erOv07D2y4y 9AMW5oc3QEQIfLLYsV55DOcP/RXaeNDMd9rNkYoQv9ESS1xdgg33vVPlJ6r2MbVngM 7TbwmaMUa7zxg== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DB956120225; Fri, 26 Mar 2021 12:32:32 -0400 (EDT) In-Reply-To: <878s6aaq0x.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 26 Mar 2021 15:33:18 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267079 Archived-At: >>> What's the performance impact here? This is going to be called a whole >>> bunch of times when the user hits TAB... >> It should be OK to do the condition-case wrapping around the loop rather >> than within it, so the performance impact should be negligible. > "Around the loop" means "around completing-read", Not necessarily, e.g. Stefan diff --git a/lisp/simple.el b/lisp/simple.el index 959bd83117..91069aa02a 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1982,7 +1982,8 @@ read-extended-command (concat (cond ((eq current-prefix-arg '-) "- ") ((and (consp current-prefix-arg) - (eq (car current-prefix-arg) 4)) "C-u ") + (eq (car current-prefix-arg) 4)) + "C-u ") ((and (consp current-prefix-arg) (integerp (car current-prefix-arg))) (format "%d " (car current-prefix-arg))) @@ -1998,11 +1999,12 @@ read-extended-command "M-X " "M-x ")) (lambda (string pred action) - (if (and suggest-key-bindings (eq action 'metadata)) - '(metadata - (affixation-function . read-extended-command--affixation) - (category . command)) - (complete-with-action action obarray string pred))) + (with-demoted-errors "Completion error: %S" + (if (and suggest-key-bindings (eq action 'metadata)) + '(metadata + (affixation-function . read-extended-command--affixation) + (category . command)) + (complete-with-action action obarray string pred)))) (lambda (sym) (and (commandp sym) (or (null read-extended-command-predicate)