Re: [elpa] externals/setup 31dfc0f24e 2/5: Expand on how setting a "feature" sets hooks and maps.

Re: [elpa] externals/setup 31dfc0f24e 2/5: Expand on how setting a "feature" sets hooks and maps.

[Stefan Monnier]

Hi Philip,

> +- Declares a current mode by appending \"-mode\" to
> +  FEATURE, unless it already ends with \"-mode\"

BTW, this also means that the current mode *has* to end in `-mode`.

In many/most cases it's better to ask the user to write the `-mode`.
Those 5 extra letters may seem like clutter, but they simplify the
"model", so I think it's to the benefit of the end user.

Otherwise you end up with possible confusions like "does `perl` refer
to the name of the language or to the name of the mode?" whose answer
influences how you specify the setup of `cperl-mode` for example.


        Stefan

Re: [elpa] externals/setup 31dfc0f24e 2/5: Expand on how setting a "feature" sets hooks and maps.

[Philip Kaludercic]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hi Philip,
>
>> +- Declares a current mode by appending \"-mode\" to
>> +  FEATURE, unless it already ends with \"-mode\"
>
> BTW, this also means that the current mode *has* to end in `-mode`.
>
> In many/most cases it's better to ask the user to write the `-mode`.
> Those 5 extra letters may seem like clutter, but they simplify the
> "model", so I think it's to the benefit of the end user.

I had been thinking about this recently, and I do think that I made a
mistake in adding too many of these "dwim" features.  This commit just
documents the behaviour, it doesn't add anything.

To solve the issue I would have to deprecate the current macro set and
provide a new one that could be used instead, written with the benefit
of hindsight.

> Otherwise you end up with possible confusions like "does `perl` refer
> to the name of the language or to the name of the mode?" whose answer
> influences how you specify the setup of `cperl-mode` for example.
>
>
>         Stefan

-- 
	Philip Kaludercic

Re: [elpa] externals/setup 31dfc0f24e 2/5: Expand on how setting a "feature" sets hooks and maps.

[Stefan Monnier]

> I had been thinking about this recently, and I do think that I made a
> mistake in adding too many of these "dwim" features.  This commit just
> documents the behaviour, it doesn't add anything.

Yes, I realized that, it was just the commit that prompted the thought :-)

> To solve the issue I would have to deprecate the current macro set and
> provide a new one that could be used instead, written with the benefit
> of hindsight.

You could start by emitting warnings when the arg doesn't end in
`-mode` (if you decide it's a good change, that is.  I haven't looked
at all the consequences it might have).


        Stefan