From: martin rudalics <rudalics@gmx.at>
To: Tom Gillespie <tgbugs@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org, larsi@gnus.org
Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames
Date: Sun, 29 Jan 2023 18:39:43 +0100 [thread overview]
Message-ID: <ff1bfdad-49d5-fd9e-2f2e-9d45d4f83770@gmx.at> (raw)
In-Reply-To: <CA+G3_PNDA7Kni9Xrcqbpk+z1eQ-3e2z_Q5HtSojkoznLq9hKqw@mail.gmail.com>
> Here is an updated patch which does not touch
> 'display-buffer-use-some-window' at all, and that
> corrects splitting behavior and return value for
> 'display-buffer-use-least-recent-window'.
Thanks. I see the following problems:
+ (window (or (get-lru-window frame nil not-this-window)
+ (if (not reusable-frames)
+ (display-buffer-pop-up-window buffer alist)
+ (window (get-buffer-window buffer reusable-frames)))))
Here the last line gets me
In end of data:
window.el:8522:25: Warning: the function ‘window’ is not known to be defined.
Now if this frame contains more than one window, 'get-lru-window' will
usually (barring not fullwidth, dedicated ... windows) always succeed in
finding a window. This is probably not the intended behavior if this
frame contains a reusable window - one that shows BUFFER already. Maybe
you think that some other action function would handle that. But then
why would you want to handle 'reusable-frames' here at all?
Also 'display-buffer-pop-up-window' is an action function which returns
a window _and_ displays the buffer in it. So if it succeeds here, you
will end up displaying the buffer twice, once within that function and
once in
+ (window--display-buffer buffer window 'reuse alist)
below. I can't tell you what consequences that might have but I think
it's a bad idea. BTW, you don't have to bind 'not-this-window' - just
pass t as last argument to 'get-lru-window'.
+ (window--display-buffer buffer window 'reuse alist)
This would have to become
(window--display-buffer buffer window 'window alist)
when 'display-buffer-pop-up-window' succeeds.
This
+ (prog1
has been cargo-culted from 'display-buffer-use-some-window'. It's of no
use here because you return the window used below.
Finally, please fix the doc-string so it tells what this function really
does (and please leave two spaces between sentences).
Thanks again, martin
next prev parent reply other threads:[~2023-01-29 17:39 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 5:17 [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Tom Gillespie
2023-01-27 5:25 ` Tom Gillespie
2023-01-27 6:19 ` Tom Gillespie
2023-01-27 13:03 ` Eli Zaretskii
2023-01-28 10:46 ` martin rudalics
2023-01-28 11:12 ` Eli Zaretskii
2023-01-28 15:35 ` martin rudalics
2023-01-28 16:02 ` Eli Zaretskii
2023-01-29 17:39 ` martin rudalics
2023-01-29 18:41 ` Eli Zaretskii
2023-01-29 18:50 ` Tom Gillespie
2023-01-30 16:43 ` martin rudalics
2023-01-30 17:38 ` Eli Zaretskii
2023-01-30 17:57 ` martin rudalics
2023-01-30 18:04 ` Eli Zaretskii
2023-01-31 8:45 ` martin rudalics
2023-01-31 14:01 ` Eli Zaretskii
2023-02-01 10:45 ` martin rudalics
2023-02-01 17:38 ` Eli Zaretskii
2023-02-01 18:33 ` martin rudalics
2023-01-28 19:04 ` Tom Gillespie
2023-01-28 20:01 ` Tom Gillespie
2023-01-29 17:39 ` martin rudalics [this message]
2023-01-29 19:02 ` Tom Gillespie
2023-01-30 16:44 ` martin rudalics
2023-01-30 17:43 ` Tom Gillespie
2023-01-30 17:58 ` martin rudalics
2023-01-30 19:40 ` Tom Gillespie
2023-01-30 22:45 ` Tom Gillespie
2023-01-31 8:46 ` martin rudalics
2023-01-31 18:38 ` Tom Gillespie
2023-02-01 9:08 ` martin rudalics
2023-02-01 17:19 ` Tom Gillespie
2023-02-01 18:32 ` martin rudalics
2023-02-02 16:39 ` martin rudalics
2023-02-02 19:57 ` Tom Gillespie
2023-02-03 9:09 ` martin rudalics
2023-02-11 15:44 ` Eli Zaretskii
2023-02-11 18:15 ` Tom Gillespie
2023-02-12 9:33 ` martin rudalics
2023-02-18 17:46 ` Eli Zaretskii
2023-02-20 9:03 ` martin rudalics
2023-02-20 11:55 ` Eli Zaretskii
2023-02-20 18:14 ` martin rudalics
2023-02-21 12:02 ` Eli Zaretskii
2023-01-31 8:46 ` martin rudalics
2023-01-29 17:48 ` Juri Linkov
2023-01-29 18:48 ` Eli Zaretskii
2023-02-06 10:01 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff1bfdad-49d5-fd9e-2f2e-9d45d4f83770@gmx.at \
--to=rudalics@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=tgbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).