From: Tom Gillespie <tgbugs@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org, larsi@gnus.org
Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames
Date: Mon, 30 Jan 2023 14:40:31 -0500 [thread overview]
Message-ID: <CA+G3_PNLyA53k5TuOFxNUr-aJ+e8j_SgGJzpKcwaoWG-i3QfWw@mail.gmail.com> (raw)
In-Reply-To: <c054f142-3abb-ae84-dd3f-0aa5a0208bdd@gmx.at>
> Why? Any reusable frame would have been already honored by
'display-buffer-reuse-window'.
If 'display-buffer-reuse-window' fails to find a valid window then
the next function to run will be 'display-buffer-use-some-window'.
In the current implementation of 'display-buffer-use-some-window'
get-lru-window only searches the existing frame and not-this-window
will be true, therefore whenever there is a single window in the
current frame 'display-buffer-use-some-window' will proceed on to
pick a window in another frame starting with visible then 0 for all-frames
when it calls
(get-largest-window 'visible nil not-this-window) and then
(get-largest-window 0 nil not-this-window)
This is not the behavior that we want because a single window in the
current frame will never be able to reach display-buffer-pop-up-window
since 'display-buffer-use-some-window' will succeed on a random window
in a random frame which will almost certainly not be the least recently used.
> Why would you want to change 'display-buffer-use-some-window'?
I don't, but in your example where we call it in
display-buffer-use-least-recent-window then it would have to be
modified since as is it is impossible to get the behavior we need
due to the calls to get-largest-window.
next prev parent reply other threads:[~2023-01-30 19:40 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 5:17 [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Tom Gillespie
2023-01-27 5:25 ` Tom Gillespie
2023-01-27 6:19 ` Tom Gillespie
2023-01-27 13:03 ` Eli Zaretskii
2023-01-28 10:46 ` martin rudalics
2023-01-28 11:12 ` Eli Zaretskii
2023-01-28 15:35 ` martin rudalics
2023-01-28 16:02 ` Eli Zaretskii
2023-01-29 17:39 ` martin rudalics
2023-01-29 18:41 ` Eli Zaretskii
2023-01-29 18:50 ` Tom Gillespie
2023-01-30 16:43 ` martin rudalics
2023-01-30 17:38 ` Eli Zaretskii
2023-01-30 17:57 ` martin rudalics
2023-01-30 18:04 ` Eli Zaretskii
2023-01-31 8:45 ` martin rudalics
2023-01-31 14:01 ` Eli Zaretskii
2023-02-01 10:45 ` martin rudalics
2023-02-01 17:38 ` Eli Zaretskii
2023-02-01 18:33 ` martin rudalics
2023-01-28 19:04 ` Tom Gillespie
2023-01-28 20:01 ` Tom Gillespie
2023-01-29 17:39 ` martin rudalics
2023-01-29 19:02 ` Tom Gillespie
2023-01-30 16:44 ` martin rudalics
2023-01-30 17:43 ` Tom Gillespie
2023-01-30 17:58 ` martin rudalics
2023-01-30 19:40 ` Tom Gillespie [this message]
2023-01-30 22:45 ` Tom Gillespie
2023-01-31 8:46 ` martin rudalics
2023-01-31 18:38 ` Tom Gillespie
2023-02-01 9:08 ` martin rudalics
2023-02-01 17:19 ` Tom Gillespie
2023-02-01 18:32 ` martin rudalics
2023-02-02 16:39 ` martin rudalics
2023-02-02 19:57 ` Tom Gillespie
2023-02-03 9:09 ` martin rudalics
2023-02-11 15:44 ` Eli Zaretskii
2023-02-11 18:15 ` Tom Gillespie
2023-02-12 9:33 ` martin rudalics
2023-02-18 17:46 ` Eli Zaretskii
2023-02-20 9:03 ` martin rudalics
2023-02-20 11:55 ` Eli Zaretskii
2023-02-20 18:14 ` martin rudalics
2023-02-21 12:02 ` Eli Zaretskii
2023-01-31 8:46 ` martin rudalics
2023-01-29 17:48 ` Juri Linkov
2023-01-29 18:48 ` Eli Zaretskii
2023-02-06 10:01 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+G3_PNLyA53k5TuOFxNUr-aJ+e8j_SgGJzpKcwaoWG-i3QfWw@mail.gmail.com \
--to=tgbugs@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).