unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Handling of links with portable dumper
@ 2019-04-04 22:39 Richard Stallman
  2019-04-05  5:42 ` Eli Zaretskii
  0 siblings, 1 reply; 15+ messages in thread
From: Richard Stallman @ 2019-04-04 22:39 UTC (permalink / raw)
  To: emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

A month ago I built master but my use of a symlink in ~/bin
made it not load.

Has that problem been fixed?

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-04 22:39 Handling of links with portable dumper Richard Stallman
@ 2019-04-05  5:42 ` Eli Zaretskii
  2019-04-05 22:32   ` Richard Stallman
  0 siblings, 1 reply; 15+ messages in thread
From: Eli Zaretskii @ 2019-04-05  5:42 UTC (permalink / raw)
  To: rms; +Cc: emacs-devel

> From: Richard Stallman <rms@gnu.org>
> Date: Thu, 04 Apr 2019 18:39:26 -0400
> 
> A month ago I built master but my use of a symlink in ~/bin
> made it not load.
> 
> Has that problem been fixed?

No, not yet.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-05  5:42 ` Eli Zaretskii
@ 2019-04-05 22:32   ` Richard Stallman
  2019-04-06  6:30     ` Eli Zaretskii
  2019-04-06 22:29     ` Stefan Monnier
  0 siblings, 2 replies; 15+ messages in thread
From: Richard Stallman @ 2019-04-05 22:32 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

Would you please fix that problem soon?

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-05 22:32   ` Richard Stallman
@ 2019-04-06  6:30     ` Eli Zaretskii
  2019-04-06 23:24       ` Richard Stallman
  2019-04-06 22:29     ` Stefan Monnier
  1 sibling, 1 reply; 15+ messages in thread
From: Eli Zaretskii @ 2019-04-06  6:30 UTC (permalink / raw)
  To: rms, Paul Eggert, Daniel Colascione; +Cc: emacs-devel

> From: Richard Stallman <rms@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Fri, 05 Apr 2019 18:32:11 -0400
> 
> Would you please fix that problem soon?

I cannot test it well enough, and I don't think I understand well
enough the problem and its intended solutions, so I didn't try.
Perhaps Paul or Daniel (CC'ed) or someone else could do that.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-05 22:32   ` Richard Stallman
  2019-04-06  6:30     ` Eli Zaretskii
@ 2019-04-06 22:29     ` Stefan Monnier
  2019-04-07 21:58       ` Richard Stallman
  1 sibling, 1 reply; 15+ messages in thread
From: Stefan Monnier @ 2019-04-06 22:29 UTC (permalink / raw)
  To: emacs-devel

> Would you please fix that problem soon?

FWIW I circumvented it by replacing the symlink with a script.


        Stefan




^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-06  6:30     ` Eli Zaretskii
@ 2019-04-06 23:24       ` Richard Stallman
  2019-04-07  2:41         ` Eli Zaretskii
  0 siblings, 1 reply; 15+ messages in thread
From: Richard Stallman @ 2019-04-06 23:24 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: eggert, dancol, emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I cannot test it well enough, and I don't think I understand well
  > enough the problem and its intended solutions, so I didn't try.

Put ~/bin in your path.  Make a symlink from ~/bin/emcs to the executable
of Emacs that you built from master.

Then run emcs and you'll see that it does not find the dump file.  By
stepping through the code that searches for the dump file, you can see
where it goes wrong.

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-06 23:24       ` Richard Stallman
@ 2019-04-07  2:41         ` Eli Zaretskii
  2019-04-07 17:04           ` Daniel Colascione
  0 siblings, 1 reply; 15+ messages in thread
From: Eli Zaretskii @ 2019-04-07  2:41 UTC (permalink / raw)
  To: rms; +Cc: eggert, dancol, emacs-devel

> From: Richard Stallman <rms@gnu.org>
> Cc: eggert@cs.ucla.edu, dancol@dancol.org, emacs-devel@gnu.org
> Date: Sat, 06 Apr 2019 19:24:15 -0400
> 
>   > I cannot test it well enough, and I don't think I understand well
>   > enough the problem and its intended solutions, so I didn't try.
> 
> Put ~/bin in your path.  Make a symlink from ~/bin/emcs to the executable
> of Emacs that you built from master.

That's not the part I didn't understand well enough.  There are other
complications that were discussed at the time, I don't even remember
the details anymore.

Sorry, someone else will have to work on this.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-07  2:41         ` Eli Zaretskii
@ 2019-04-07 17:04           ` Daniel Colascione
  2019-04-07 17:44             ` Paul Eggert
                               ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Daniel Colascione @ 2019-04-07 17:04 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: eggert, dancol, rms, emacs-devel

>> From: Richard Stallman <rms@gnu.org>
>> Cc: eggert@cs.ucla.edu, dancol@dancol.org, emacs-devel@gnu.org
>> Date: Sat, 06 Apr 2019 19:24:15 -0400
>>
>>   > I cannot test it well enough, and I don't think I understand well
>>   > enough the problem and its intended solutions, so I didn't try.
>>
>> Put ~/bin in your path.  Make a symlink from ~/bin/emcs to the
>> executable
>> of Emacs that you built from master.
>
> That's not the part I didn't understand well enough.  There are other
> complications that were discussed at the time, I don't even remember
> the details anymore.
>
> Sorry, someone else will have to work on this.

I broke it, so I'll buy it. I'll fix this. Paul, is there something in
gnulib I can just link to?




^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-07 17:04           ` Daniel Colascione
@ 2019-04-07 17:44             ` Paul Eggert
  2019-04-07 22:07               ` Clément Pit-Claudel
  2019-04-07 18:15             ` Eli Zaretskii
  2019-04-08 22:00             ` Richard Stallman
  2 siblings, 1 reply; 15+ messages in thread
From: Paul Eggert @ 2019-04-07 17:44 UTC (permalink / raw)
  To: Daniel Colascione, Eli Zaretskii; +Cc: rms, emacs-devel

Daniel Colascione wrote:
> Paul, is there something in
> gnulib I can just link to?

Sorry, I've lost context. What function do you want? canonicalize_file_name? 
set_program_name_and_installdir? I'm not a big fan of the latter, as it's a 
portability heavyweight (it makes lots of assumptions and might not be 
applicable to Emacs).

I still think it'd be better to put the dump into the executable itself, which 
can be done portably simply by linking a big C character array into the 
executable. in the long run this will be better for users (and for us) than 
fiddling with portability minefields like set_program_name_and_installdir.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-07 17:04           ` Daniel Colascione
  2019-04-07 17:44             ` Paul Eggert
@ 2019-04-07 18:15             ` Eli Zaretskii
  2019-04-08 22:00             ` Richard Stallman
  2 siblings, 0 replies; 15+ messages in thread
From: Eli Zaretskii @ 2019-04-07 18:15 UTC (permalink / raw)
  To: Daniel Colascione; +Cc: eggert, dancol, rms, emacs-devel

> Date: Sun, 7 Apr 2019 10:04:05 -0700
> From: "Daniel Colascione" <dancol@dancol.org>
> Cc: eggert@cs.ucla.edu, dancol@dancol.org, rms@gnu.org, emacs-devel@gnu.org
> 
> I broke it, so I'll buy it. I'll fix this.

Thanks.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-06 22:29     ` Stefan Monnier
@ 2019-04-07 21:58       ` Richard Stallman
  0 siblings, 0 replies; 15+ messages in thread
From: Richard Stallman @ 2019-04-07 21:58 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > Would you please fix that problem soon?

  > FWIW I circumvented it by replacing the symlink with a script.

Many bugs can be worked around, but this regression ought
to be fixed.


-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-07 17:44             ` Paul Eggert
@ 2019-04-07 22:07               ` Clément Pit-Claudel
  2019-04-08  4:04                 ` Michael Welsh Duggan
  0 siblings, 1 reply; 15+ messages in thread
From: Clément Pit-Claudel @ 2019-04-07 22:07 UTC (permalink / raw)
  To: emacs-devel

On 2019-04-07 13:44, Paul Eggert wrote:
> I still think it'd be better to put the dump into the executable
> itself, which can be done portably simply by linking a big C
> character array into the executable. in the long run this will be
> better for users (and for us) than fiddling with portability
> minefields like set_program_name_and_installdir.

Does that mean also rewriting the full binary when we rewrite the dump?



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-07 22:07               ` Clément Pit-Claudel
@ 2019-04-08  4:04                 ` Michael Welsh Duggan
  2019-04-08  4:08                   ` Paul Eggert
  0 siblings, 1 reply; 15+ messages in thread
From: Michael Welsh Duggan @ 2019-04-08  4:04 UTC (permalink / raw)
  To: emacs-devel

Clément Pit-Claudel <cpitclaudel@gmail.com> writes:

> On 2019-04-07 13:44, Paul Eggert wrote:
>> I still think it'd be better to put the dump into the executable
>> itself, which can be done portably simply by linking a big C
>> character array into the executable. in the long run this will be
>> better for users (and for us) than fiddling with portability
>> minefields like set_program_name_and_installdir.
>
> Does that mean also rewriting the full binary when we rewrite the dump?

I would assume that when the executable was built it would be dumped
with the dump file created at that time, but that that emacs could load
a different dump file than the one built into it.  I don't see a good
portable way to re-make the executable after the fact absent going back
to the source build, though.

-- 
Michael Welsh Duggan
(md5i@md5i.com)



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-08  4:04                 ` Michael Welsh Duggan
@ 2019-04-08  4:08                   ` Paul Eggert
  0 siblings, 0 replies; 15+ messages in thread
From: Paul Eggert @ 2019-04-08  4:08 UTC (permalink / raw)
  To: emacs-devel

Michael Welsh Duggan wrote:
>> Does that mean also rewriting the full binary when we rewrite the dump?
> I would assume that when the executable was built it would be dumped
> with the dump file created at that time, but that that emacs could load
> a different dump file than the one built into it

Yes, the idea is to augment the current approach, not replace it. You'd still be 
able to use the current approach if you wanted to. The default installation 
would be to have a single file rather than two, that's all.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Handling of links with portable dumper
  2019-04-07 17:04           ` Daniel Colascione
  2019-04-07 17:44             ` Paul Eggert
  2019-04-07 18:15             ` Eli Zaretskii
@ 2019-04-08 22:00             ` Richard Stallman
  2 siblings, 0 replies; 15+ messages in thread
From: Richard Stallman @ 2019-04-08 22:00 UTC (permalink / raw)
  To: Daniel Colascione; +Cc: eliz, eggert, dancol, emacs-devel

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > >> Put ~/bin in your path.  Make a symlink from ~/bin/emcs to the
  > >> executable
  > >> of Emacs that you built from master.

  > I broke it, so I'll buy it. I'll fix this. Paul, is there something in
  > gnulib I can just link to?

I don't know about gnulib, but if you look at the code that sets
up Vinstallation_directory, also in emacs.c, you can see how it
calls readlink.  It should work to copy and adapt that code.

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)





^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2019-04-08 22:00 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-04 22:39 Handling of links with portable dumper Richard Stallman
2019-04-05  5:42 ` Eli Zaretskii
2019-04-05 22:32   ` Richard Stallman
2019-04-06  6:30     ` Eli Zaretskii
2019-04-06 23:24       ` Richard Stallman
2019-04-07  2:41         ` Eli Zaretskii
2019-04-07 17:04           ` Daniel Colascione
2019-04-07 17:44             ` Paul Eggert
2019-04-07 22:07               ` Clément Pit-Claudel
2019-04-08  4:04                 ` Michael Welsh Duggan
2019-04-08  4:08                   ` Paul Eggert
2019-04-07 18:15             ` Eli Zaretskii
2019-04-08 22:00             ` Richard Stallman
2019-04-06 22:29     ` Stefan Monnier
2019-04-07 21:58       ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).