Re: scratch/tzz/auth-source-reveal-mode dbe62dd: doc/misc/auth.texi: shorten use-package example

Re: scratch/tzz/auth-source-reveal-mode dbe62dd: doc/misc/auth.texi: shorten use-package example

[Stefan Monnier]

> diff --git a/doc/misc/auth.texi b/doc/misc/auth.texi
> index 30cb6fb..bb632ba 100644
> --- a/doc/misc/auth.texi
> +++ b/doc/misc/auth.texi
> @@ -305,9 +305,7 @@ An alternative is to enable @code{auth-source-reveal-mode} as follows:
>    :custom
>    (prettify-symbols-unprettify-at-point 'right-edge)
>    :hook
> -  (prog-mode . auth-source-reveal-mode)
> -  (json-mode . auth-source-reveal-mode)
> -  (text-mode . auth-source-reveal-mode))
> +  ((prog-mode js2-mode text-mode) . auth-source-reveal-mode))
>  @end example
>  
>  You should definitely customize

I think that since use-package is (still!) not in Emacs (and not even in
GNU ELPA), the doc shouldn't rely on it.


        Stefan

Re: scratch/tzz/auth-source-reveal-mode dbe62dd: doc/misc/auth.texi: shorten use-package example

[Dmitry Gutov]

On 19.06.2020 00:26, Teodor Zlatanov wrote:
> +  ((prog-mode js2-mode text-mode) . auth-source-reveal-mode))

js2-mode inherits from prog-mode, doesn't it?

Re: scratch/tzz/auth-source-reveal-mode dbe62dd: doc/misc/auth.texi: shorten use-package example

[Basil L. Contovounesios]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> diff --git a/doc/misc/auth.texi b/doc/misc/auth.texi
>> index 30cb6fb..bb632ba 100644
>> --- a/doc/misc/auth.texi
>> +++ b/doc/misc/auth.texi
>> @@ -305,9 +305,7 @@ An alternative is to enable @code{auth-source-reveal-mode} as follows:
>>    :custom
>>    (prettify-symbols-unprettify-at-point 'right-edge)
>>    :hook
>> -  (prog-mode . auth-source-reveal-mode)
>> -  (json-mode . auth-source-reveal-mode)
>> -  (text-mode . auth-source-reveal-mode))
>> +  ((prog-mode js2-mode text-mode) . auth-source-reveal-mode))
>>  @end example
>>  
>>  You should definitely customize
>
> I think that since use-package is (still!) not in Emacs (and not even in
> GNU ELPA), the doc shouldn't rely on it.

For anyone interested in following its Emacsimilation:
https://github.com/jwiegley/use-package/issues/282

-- 
Basil

Re: scratch/tzz/auth-source-reveal-mode dbe62dd: doc/misc/auth.texi: shorten use-package example

[Ted Zlatanov]

On Fri, 19 Jun 2020 00:58:55 +0100 "Basil L. Contovounesios" <contovob@tcd.ie> wrote: 

BLC> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I think that since use-package is (still!) not in Emacs (and not even in
>> GNU ELPA), the doc shouldn't rely on it.

BLC> For anyone interested in following its Emacsimilation:
BLC> https://github.com/jwiegley/use-package/issues/282

The doc says "if you prefer use-package..." which is not IMO a
dependency or an endorsement, just a convenience. Also as Basil pointed
out, it's very likely that use-package will be in ELPA or core Emacs
soon, so maybe we can be a little bit lenient?

If you feel this is better left out until after use-package gets the
copyright assignments, I'll remove the example configuration.

On Fri, 19 Jun 2020 00:44:21 +0300 Dmitry Gutov <dgutov@yandex.ru> wrote: 

DG> js2-mode inherits from prog-mode, doesn't it?

Ah, good catch, fixed.

Ted

Re: scratch/tzz/auth-source-reveal-mode dbe62dd: doc/misc/auth.texi: shorten use-package example

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > If you feel this is better left out until after use-package gets the
  > copyright assignments, I'll remove the example configuration.

Please write documentation to show how to use Emacs by itself, not
Emacs plus external add-ons.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: scratch/tzz/auth-source-reveal-mode dbe62dd: doc/misc/auth.texi: shorten use-package example

[Ted Zlatanov]

On Fri, 19 Jun 2020 23:10:55 -0400 Richard Stallman <rms@gnu.org> wrote: 

>> If you feel this is better left out until after use-package gets the
>> copyright assignments, I'll remove the example configuration.

RS> Please write documentation to show how to use Emacs by itself, not
RS> Emacs plus external add-ons.

OK, I've removed that example.

I've rebased and pushed the latest code to
scratch/tzz/auth-source-reveal-mode and will merge it to master tomorrow
if there are no further objections.

Thank you
Ted