* [PATCH] Let git ignore src/temacs* not just src/temacs @ 2019-05-18 14:49 Bastien 2019-05-18 16:10 ` Stefan Monnier 2019-05-18 17:24 ` Paul Eggert 0 siblings, 2 replies; 5+ messages in thread From: Bastien @ 2019-05-18 14:49 UTC (permalink / raw) To: emacs-devel [-- Attachment #1: Type: text/plain, Size: 177 bytes --] I found a remaining src/temacs.in that is not ignored right now. I suggest ignoring src/temacs*, not just src/temacs. Let me know if I can apply the following patch. Thanks! [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: gitignore.patch --] [-- Type: text/x-diff, Size: 307 bytes --] diff --git a/.gitignore b/.gitignore index 88b29760b7..dd68a478ef 100644 --- a/.gitignore +++ b/.gitignore @@ -184,7 +184,7 @@ nextstep/GNUstep/Emacs.base/Resources/Info-gnustep.plist src/bootstrap-emacs src/emacs src/emacs-[0-9]* -src/temacs +src/temacs* src/fingerprint.c src/dmpstruct.h src/*.pdmp [-- Attachment #3: Type: text/plain, Size: 14 bytes --] -- Bastien ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Let git ignore src/temacs* not just src/temacs 2019-05-18 14:49 [PATCH] Let git ignore src/temacs* not just src/temacs Bastien @ 2019-05-18 16:10 ` Stefan Monnier 2019-05-18 17:24 ` Paul Eggert 1 sibling, 0 replies; 5+ messages in thread From: Stefan Monnier @ 2019-05-18 16:10 UTC (permalink / raw) To: emacs-devel > I found a remaining src/temacs.in that is not ignored right now. Previous versions of the `master` branch created this, but the current `master` branch doesn't create this any more. For this reason, `make clean` and friends don't remove this file any more (since "it's not ours" any more). Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Let git ignore src/temacs* not just src/temacs 2019-05-18 14:49 [PATCH] Let git ignore src/temacs* not just src/temacs Bastien 2019-05-18 16:10 ` Stefan Monnier @ 2019-05-18 17:24 ` Paul Eggert 2019-05-18 17:29 ` Paul Eggert 1 sibling, 1 reply; 5+ messages in thread From: Paul Eggert @ 2019-05-18 17:24 UTC (permalink / raw) To: Bastien, emacs-devel Bastien wrote: > Let me know if I can apply the following patch. Sure, that makes sense. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Let git ignore src/temacs* not just src/temacs 2019-05-18 17:24 ` Paul Eggert @ 2019-05-18 17:29 ` Paul Eggert 2019-05-18 18:23 ` Bastien 0 siblings, 1 reply; 5+ messages in thread From: Paul Eggert @ 2019-05-18 17:29 UTC (permalink / raw) To: Bastien, emacs-devel Paul Eggert wrote: > Bastien wrote: >> Let me know if I can apply the following patch. > > Sure, that makes sense. Hmm, well, as Stefan points out it *used* to make sense, but nowadays it shouldn't be needed. Sorry about the noise. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Let git ignore src/temacs* not just src/temacs 2019-05-18 17:29 ` Paul Eggert @ 2019-05-18 18:23 ` Bastien 0 siblings, 0 replies; 5+ messages in thread From: Bastien @ 2019-05-18 18:23 UTC (permalink / raw) To: Paul Eggert; +Cc: emacs-devel Paul Eggert <eggert@cs.ucla.edu> writes: > Paul Eggert wrote: >> Bastien wrote: >>> Let me know if I can apply the following patch. >> >> Sure, that makes sense. > > Hmm, well, as Stefan points out it *used* to make sense, but nowadays > it shouldn't be needed. Sorry about the noise. Okay, point taken. Thanks, -- Bastien ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-18 18:23 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-05-18 14:49 [PATCH] Let git ignore src/temacs* not just src/temacs Bastien 2019-05-18 16:10 ` Stefan Monnier 2019-05-18 17:24 ` Paul Eggert 2019-05-18 17:29 ` Paul Eggert 2019-05-18 18:23 ` Bastien
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).