Re: master 7d47651d01: project-buffers: Describe the default implementation

Re: master 7d47651d01: project-buffers: Describe the default implementation

[Eli Zaretskii]

> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index ec453baf72..6d062aa8fa 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -353,7 +353,10 @@ Also quote LOCAL-FILES if `default-directory' is quoted."
>                local-files))))
>  
>  (cl-defgeneric project-buffers (project)
> -  "Return the list of all live buffers that belong to PROJECT."
> +  "Return the list of all live buffers that belong to PROJECT.
> +
> +The default implementation matches the current open buffers to
> +PROJECT root using the value of `default-directory' in each one."

What does it mean "the current open buffers"?  I don't think we use
the term "open buffer" in our documentation.  Do you mean the
"existing buffers"? or maybe just "buffers"?

IOW, what aspects of buffers is the "current open" qualification
trying to capture?

Thanks.

Re: master 7d47651d01: project-buffers: Describe the default implementation

[Dmitry Gutov]

On 04.11.2022 10:15, Eli Zaretskii wrote:
> What does it mean "the current open buffers"?  I don't think we use
> the term "open buffer" in our documentation.  Do you mean the
> "existing buffers"? or maybe just "buffers"?

I've changed that to "existing buffers". Thanks!

Re: master 7d47651d01: project-buffers: Describe the default implementation

[Eli Zaretskii]

> Date: Fri, 4 Nov 2022 12:41:32 +0200
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> 
> On 04.11.2022 10:15, Eli Zaretskii wrote:
> > What does it mean "the current open buffers"?  I don't think we use
> > the term "open buffer" in our documentation.  Do you mean the
> > "existing buffers"? or maybe just "buffers"?
> 
> I've changed that to "existing buffers". Thanks!

Thanks, but does that mean buffers created later will not be matched
according to their default-directory value?  Why should we say
"existing" here?

Re: master 7d47651d01: project-buffers: Describe the default implementation

[Dmitry Gutov]

On 04.11.2022 13:49, Eli Zaretskii wrote:
> Thanks, but does that mean buffers created later will not be matched
> according to their default-directory value?  Why should we say
> "existing" here?

Later than what?

Re: master 7d47651d01: project-buffers: Describe the default implementation

[Dmitry Gutov]

On 04.11.2022 13:49, Eli Zaretskii wrote:
> Why should we say
> "existing" here?

The flow of the sentence doesn't work as well without an adjective, I'd 
say. But please feel free to remove it.

Re: master 7d47651d01: project-buffers: Describe the default implementation

[Eli Zaretskii]

> Date: Fri, 4 Nov 2022 13:51:58 +0200
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> 
> On 04.11.2022 13:49, Eli Zaretskii wrote:
> > Thanks, but does that mean buffers created later will not be matched
> > according to their default-directory value?  Why should we say
> > "existing" here?
> 
> Later than what?

Later than the call to this method.

IOW, I'm asking why do we have to mention "existing" at all.  What is
wrong or inaccurate with saying

 The default implementation matches each buffer to PROJECT root using
 the buffer's value of `default-directory'.

Re: master 7d47651d01: project-buffers: Describe the default implementation

[Dmitry Gutov]

On 04.11.2022 14:13, Eli Zaretskii wrote:
>   The default implementation matches each buffer to PROJECT root using
>   the buffer's value of `default-directory'.

This sounds fine to me as well.

Re: master 7d47651d01: project-buffers: Describe the default implementation

[Eli Zaretskii]

> Date: Fri, 4 Nov 2022 15:38:06 +0200
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> 
> On 04.11.2022 14:13, Eli Zaretskii wrote:
> >   The default implementation matches each buffer to PROJECT root using
> >   the buffer's value of `default-directory'.
> 
> This sounds fine to me as well.

Thanks, I installed the change.