From: Paul Eggert <eggert@cs.ucla.edu>
To: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: master eb37e4814e 3/3: Fix unlikely null pointer dereference
Date: Sat, 28 May 2022 10:14:43 -0700 [thread overview]
Message-ID: <e778790d-c971-e48b-81c9-7351be5dc491@cs.ucla.edu> (raw)
In-Reply-To: <87czfyeb5u.fsf@yahoo.com>
On 5/27/22 17:46, Po Lu wrote:
> How can name be NULL if had_errors_p is false? x_get_atom_name always
> returns something if need_sync is false, and XGetAtomName always returns
> a string unless an error occured.
Oh, you're right - I hadn't noticed that. So my recent patch didn't fix
any runtime bugs, though it did pacify GCC and I hope made the confusing
code a bit easier to follow for humans too.
I see you made further improvements in the area; thanks.
next prev parent reply other threads:[~2022-05-28 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165367719442.14912.2771599004379547518@vcs2.savannah.gnu.org>
[not found] ` <20220527184637.984F7C01683@vcs2.savannah.gnu.org>
2022-05-28 0:46 ` master eb37e4814e 3/3: Fix unlikely null pointer dereference Po Lu
2022-05-28 17:14 ` Paul Eggert [this message]
2022-05-29 0:30 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e778790d-c971-e48b-81c9-7351be5dc491@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).