From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master eb37e4814e 3/3: Fix unlikely null pointer dereference Date: Sat, 28 May 2022 10:14:43 -0700 Organization: UCLA Computer Science Department Message-ID: References: <165367719442.14912.2771599004379547518@vcs2.savannah.gnu.org> <20220527184637.984F7C01683@vcs2.savannah.gnu.org> <87czfyeb5u.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18104"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 28 19:16:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nv03a-0004Uv-DA for ged-emacs-devel@m.gmane-mx.org; Sat, 28 May 2022 19:16:54 +0200 Original-Received: from localhost ([::1]:55974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nv03Z-0004kI-1O for ged-emacs-devel@m.gmane-mx.org; Sat, 28 May 2022 13:16:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nv01Z-0003ZA-Ef for emacs-devel@gnu.org; Sat, 28 May 2022 13:14:49 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nv01W-0001SX-Ll for emacs-devel@gnu.org; Sat, 28 May 2022 13:14:48 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0582C160091; Sat, 28 May 2022 10:14:45 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Q_r47v0AmEZt; Sat, 28 May 2022 10:14:44 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5462F160172; Sat, 28 May 2022 10:14:44 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id tJSrir02zQZ2; Sat, 28 May 2022 10:14:44 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 20D13160091; Sat, 28 May 2022 10:14:44 -0700 (PDT) Content-Language: en-US In-Reply-To: <87czfyeb5u.fsf@yahoo.com> Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290342 Archived-At: On 5/27/22 17:46, Po Lu wrote: > How can name be NULL if had_errors_p is false? x_get_atom_name always > returns something if need_sync is false, and XGetAtomName always returns > a string unless an error occured. Oh, you're right - I hadn't noticed that. So my recent patch didn't fix any runtime bugs, though it did pacify GCC and I hope made the confusing code a bit easier to follow for humans too. I see you made further improvements in the area; thanks.