Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Uwe Brauer]

Hi

The last master commit I successfully compiled was 3df7d06d from 23th
December. 

Using my usual configuration 
./configure --prefix=/opt/emacs27 --with-x-toolkit=athena --with-mailutils

I obtained the following error with commit c4687d920db081f29e93cca8156793d545a827e2

  CC       widget.o
make -C ../admin/charsets all
make[3]: Entering directory '/home/oub/src/emacs/admin/charsets'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/oub/src/emacs/admin/charsets'
make -C ../admin/unidata charscript.el
make[3]: Entering directory '/home/oub/src/emacs/admin/unidata'
make[3]: Nothing to be done for 'charscript.el'.
make[3]: Leaving directory '/home/oub/src/emacs/admin/unidata'
  CCLD     temacs
/usr/bin/ld: cannot find -lpng12
collect2: error: ld returned 1 exit status
Makefile:651: recipe for target 'temacs' failed
make[2]: *** [temacs] Error 1
make[2]: Leaving directory '/home/oub/src/emacs/src'
Makefile:424: recipe for target 'src' failed
make[1]: *** [src] Error 2
make[1]: Leaving directory '/home/oub/src/emacs'
Makefile:1117: recipe for target 'bootstrap' failed
make: *** [bootstrap] Error 2


So png12 is missing, why did compile me tell about it?

Any solution?

Uwe Brauer 

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Paul Eggert]

On 1/23/20 12:09 PM, Uwe Brauer wrote:
> So png12 is missing, why did compile me tell about it?

I guess your pkg-config claimed that you have a working libpng, even though you 
don't. Try running the following shell commands:

pkg-config --cflags "libpng >= 1.0.0"
pkg-config --libs "libpng >= 1.0.0"

If these commands tell 'configure' to use flags like -lpng12 but those flags 
don't work, then you have a problem with your pkg-config installation somewhere.

Although you can work around the problem by building Emacs with './configure 
--without-png', it's better to get your png installation whipped into shape.

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

>>> "PE" == Paul Eggert <eggert@cs.ucla.edu> writes:

   > On 1/23/20 12:09 PM, Uwe Brauer wrote:
   >> So png12 is missing, why did compile me tell about it?

   > I guess your pkg-config claimed that you have a working libpng, even
   > though you don't. Try running the following shell commands:

   > pkg-config --cflags "libpng >= 1.0.0"
   > pkg-config --libs "libpng >= 1.0.0"

I obtain

pkg-config --cflags "libpng >= 1.0.0"

-I/usr/include/libpng16


pkg-config --libs "libpng >= 1.0.0"

-lpng16 -lz

   > If these commands tell 'configure' to use flags like -lpng12 but those
   > flags don't work, then you have a problem with your pkg-config
   > installation somewhere.

Well it seems that they should say lpng16 and the don't 

   > Although you can work around the problem by building Emacs with
   > './configure --without-png', it's better to get your png installation
   > whipped into shape.

--without-png is not a solution for me.


Any why on earth could I compile still on 23 of December? What changed, 
shall I bisect the problem?


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Robert Pluim]

>>>>> On Fri, 24 Jan 2020 09:52:55 +0100, Uwe Brauer <oub@mat.ucm.es> said:

    >>>> "PE" == Paul Eggert <eggert@cs.ucla.edu> writes:
    >> On 1/23/20 12:09 PM, Uwe Brauer wrote:
    >>> So png12 is missing, why did compile me tell about it?

    >> I guess your pkg-config claimed that you have a working libpng, even
    >> though you don't. Try running the following shell commands:

    >> pkg-config --cflags "libpng >= 1.0.0"
    >> pkg-config --libs "libpng >= 1.0.0"

    Uwe> I obtain

    Uwe> pkg-config --cflags "libpng >= 1.0.0"

    Uwe> -I/usr/include/libpng16


    Uwe> pkg-config --libs "libpng >= 1.0.0"

    Uwe> -lpng16 -lz

    >> If these commands tell 'configure' to use flags like -lpng12 but those
    >> flags don't work, then you have a problem with your pkg-config
    >> installation somewhere.

    Uwe> Well it seems that they should say lpng16 and the don't 

    >> Although you can work around the problem by building Emacs with
    >> './configure --without-png', it's better to get your png installation
    >> whipped into shape.

    Uwe> --without-png is not a solution for me.


    Uwe> Any why on earth could I compile still on 23 of December? What changed, 
    Uwe> shall I bisect the problem?

Did you install a newer package for png and not re-run configure?

Robert

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Paul Eggert]

On 1/24/20 12:52 AM, Uwe Brauer wrote:
> Well it seems that they should say lpng16 and the don't

In that case I suggest debugging 'configure' to see why it outputs '-lpng12' 
even though you haved png16 installed.

In some cases there can be multiple pkg-config installations and perhaps you've 
picked up the wrong one. You may need to set (or unset) PKG_CONFIG_LIBDIR in 
your environment, before you run 'configure'.

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]

>>> "PE" == Paul Eggert <eggert@cs.ucla.edu> writes:

   > On 1/24/20 12:52 AM, Uwe Brauer wrote:
   >> Well it seems that they should say lpng16 and the don't

   > In that case I suggest debugging 'configure' to see why it outputs
   > '-lpng12' even though you haved png16 installed.
I am sure how to debugg configure.

   > In some cases there can be multiple pkg-config installations and
   > perhaps you've picked up the wrong one. You may need to set (or unset)
   > PKG_CONFIG_LIBDIR in your environment, before you run 'configure'.

Config.log looks like this
pkg_cv_CAIRO_CFLAGS='-I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16'
pkg_cv_LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'
pkg_cv_PNG_CFLAGS=-I/usr/include/libpng16
pkg_cv_PNG_LIBS='-lpng16 -lz'
CAIRO_CFLAGS='-isystem /usr/include/cairo -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/pixman-1 -isystem /usr/include/freetype2 -isystem /usr/include/libpng16'
LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'


so at some points it gets confused. I insist, the 23rd of Dezember it
was fine, I just checked, indeed 
2019-12-26 11:26:00 install libpng-dev:amd64 <none> 1.6.34-2~ubuntu16.04.1~ppa1
2019-12-26 11:26:01 install libpng-tools:amd64 <none> 1.6.34-2~ubuntu16.04.1~ppa1

the 26th I installed a different png version. I will test now, with I
still can compile master from 23 of December.

Uwe Brauer 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Eli Zaretskii]

> From: Uwe Brauer <oub@mat.ucm.es>
> Date: Fri, 24 Jan 2020 11:21:24 +0100
> Cc: Uwe Brauer <oub@mat.ucm.es>, emacs-devel@gnu.org
> 
>    > In that case I suggest debugging 'configure' to see why it outputs
>    > '-lpng12' even though you haved png16 installed.
> I am sure how to debugg configure.

By looking at config.log, and searching for "png".

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Stefan Monnier]

> pkg_cv_LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'
[...]
> LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'

I think this is part of the answer: why do the OTF settings ask for
a `png12` library?


        Stefan

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

   >> pkg_cv_LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'
   > [...]
   >> LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'

   > I think this is part of the answer: why do the OTF settings ask for
   > a `png12` library?

And why didn't do it in the past, I will try to bisect this and come back.

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

>>> "SM" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

   >> pkg_cv_LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'
   > [...]
   >> LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'

   > I think this is part of the answer: why do the OTF settings ask for
   > a `png12` library?

Ok I could finally do some testing. 

I tried again to ./configure and compile master from December 2019 and
from August 2019 which I have compiled without a problem.

And it is the same problem, although now png16 is installed configure,
sets the flag to png12.

I presume before my upgrade, I had png12.

I am not sure how to deal with it. 

    1. I don't want to run --without-png

    2. I don't want to desinstall png16 (which would be effectively the
       same, at least for emacs compiling)


Any ideas?

Uwe Brauer 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Stefan Monnier]

>    >> pkg_cv_LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'
>    > [...]
>    >> LIBOTF_LIBS='-lfreetype -lz -lpng12 -lotf -lfreetype'
>
>    > I think this is part of the answer: why do the OTF settings ask for
>    > a `png12` library?
>
> Ok I could finally do some testing. 
>
> I tried again to ./configure and compile master from December 2019 and
> from August 2019 which I have compiled without a problem.

Maybe it's a problem in the `libotf-dev` package?

>     1. I don't want to run --without-png

You can try `--without-libotf`?


        Stefan

Re: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2

[Paul Eggert]

On 1/25/20 2:20 PM, Uwe Brauer wrote:
> And it is the same problem, although now png16 is installed configure,
> sets the flag to png12.

What is the output of the following shell commands?

pkg-config --cflags libotf
pkg-config --libs libotf

If they output "-lpng12", then that's most likely the problem since 'configure' 
uses the output of these commands. You can run './configure --without-libotf' as 
Stefan suggested, or you can investigate why the pkg-config libotf configuration 
is messed up for you. I don't observe the problem on Ubuntu 18.04.3 LTS, for 
what it's worth.

[SOLVED (sort of)] (was: Ubuntu 16.04 cannot compile commit c4687d920db081f29e93cca8156793d545a827e2)

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

>>> "PE" == Paul Eggert <eggert@cs.ucla.edu> writes:

   > On 1/25/20 2:20 PM, Uwe Brauer wrote:
   >> And it is the same problem, although now png16 is installed configure,
   >> sets the flag to png12.

   > What is the output of the following shell commands?

   > pkg-config --cflags libotf
   > pkg-config --libs libotf

   > If they output "-lpng12", then that's most likely the problem since
   > 'configure' uses the output of these commands. You can run
   > './configure --without-libotf' as Stefan suggested, or you can
   > investigate why the pkg-config libotf configuration is messed up for
   > you. I don't observe the problem on Ubuntu 18.04.3 LTS, for what it's
   > worth.

Thanks. The issue was the following, I added in the past some ppa for
non-Ubuntu deb packages, when I then run 

  apt-get upgrade

libpng-dev:amd64 <none> 1.6.34-2~ubuntu16.04.1~ppa1

Was installed, which is not the official Ubuntu version. Although the
library worked  on my distribution, somehow configure got confused,
detected 1.6 but also some remains of 12.

So a simple 

sudo apt-get install libpng12-dev:

Solved the problem, in the sense I, again compile emacs.

Not sure what to think about it. The main culprit is of course Ubuntu,
but that configure got confused is also not good.

Thanks for you help

Uwe 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]