From: Kevin Rodgers <ihs_4664@yahoo.com>
Subject: Re: Improving docstring for defface flyspell-duplicate
Date: Tue, 24 Jan 2006 15:15:40 -0700 [thread overview]
Message-ID: <dr68ud$4c9$1@sea.gmane.org> (raw)
In-Reply-To: <17366.24376.217183.913015@chlr5836.ch.intel.com>
Andrew M. Scott wrote:
> The docstring for defface flyspell-duplicate in flyspell.el says:
>
> "Face used for marking a misspelled word that appears twice in the
> buffer.
>
> Replacing "twice" above with "two or more times" would better reflect
> the current behavior of the code
How about "more than once"? But both our suggestions make that sentence
run longer than an 80-character line when indented.
I think that "used for marking" is odd as well (the doc string for
flyspell-incorrect is similar). How about "used to display"?
Finally, what does "appears" mean? It certainly doesn't have anything
to do with whether the duplicate word is in a visible portion of the
buffer. I think "occurs" is better.
Here's what I'd suggest:
*** flyspell.el~ Tue Jan 24 15:02:56 2006
--- flyspell.el Tue Jan 24 15:12:36 2006
***************
*** 427,433 ****
(defface flyspell-incorrect
'((((class color)) (:foreground "OrangeRed" :bold t :underline t))
(t (:bold t)))
! "Face used for marking a misspelled word in Flyspell."
:group 'flyspell)
;; backward-compatibility alias
(put 'flyspell-incorrect-face 'face-alias 'flyspell-incorrect)
--- 427,433 ----
(defface flyspell-incorrect
'((((class color)) (:foreground "OrangeRed" :bold t :underline t))
(t (:bold t)))
! "Face used to display a misspelled word in Flyspell."
:group 'flyspell)
;; backward-compatibility alias
(put 'flyspell-incorrect-face 'face-alias 'flyspell-incorrect)
***************
*** 435,441 ****
(defface flyspell-duplicate
'((((class color)) (:foreground "Gold3" :bold t :underline t))
(t (:bold t)))
! "Face used for marking a misspelled word that appears twice in the
buffer.
See also `flyspell-duplicate-distance'."
:group 'flyspell)
;; backward-compatibility alias
--- 435,441 ----
(defface flyspell-duplicate
'((((class color)) (:foreground "Gold3" :bold t :underline t))
(t (:bold t)))
! "Face used to display subsequent occurrences of a misspelled word.
See also `flyspell-duplicate-distance'."
:group 'flyspell)
;; backward-compatibility alias
> e.g. when I M-x flyspell-buffer, I regularly see more than two of the same
> words colored with defface flyspell-duplicate.
--
Kevin Rodgers
prev parent reply other threads:[~2006-01-24 22:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 17:09 Improving docstring for defface flyspell-duplicate Andrew M. Scott
2006-01-24 22:15 ` Kevin Rodgers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='dr68ud$4c9$1@sea.gmane.org' \
--to=ihs_4664@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).