From: Alexander Adolf <alexander.adolf@condition-alpha.com>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] new EUDC backends for ecomplete, and mailabbrev (with ERT tests)
Date: Mon, 28 Nov 2022 22:28:51 +0100 [thread overview]
Message-ID: <d059f1cb1d99844535d353457f1f4b01@condition-alpha.com> (raw)
In-Reply-To: <m3r0z9cg43.fsf@fitzsim.org>
Hello Thomas,
Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
> [...]
> Have you had a chance to look at Stefan's review of these new backends?
>
> It would be nice to include them before the emacs-29 branch is cut.
> [...]
Apologies for having been mute for quite a while. Life and other things
got in the way. Appreciate your patience!
I saw you pushed the two new backends, and made a couple of
improvements. Many thanks for both! Looks all good to me. I think we can
put a big green check-mark on this for now. Cool!
What remains to be discussed - from my point of view - are the changes
to message.el I was proposing. I guess at least some of the points
raised by Eric Abrahamsen also fall under this, so I guess I should
include both, you and Eric in my response to Stefan Monnier.
Many thanks and cheers,
--alexander
next prev parent reply other threads:[~2022-11-28 21:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 0:11 [PATCH] new EUDC backends for ecomplete, and mailabbrev (with ERT tests) Alexander Adolf
2022-08-17 1:47 ` Stefan Monnier
2022-11-09 2:27 ` Thomas Fitzsimmons
2022-08-18 13:14 ` Thomas Fitzsimmons
2022-10-15 14:32 ` Thomas Fitzsimmons
2022-11-28 21:28 ` Alexander Adolf [this message]
2022-11-29 0:46 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d059f1cb1d99844535d353457f1f4b01@condition-alpha.com \
--to=alexander.adolf@condition-alpha.com \
--cc=emacs-devel@gnu.org \
--cc=fitzsim@fitzsim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).