From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alexander Adolf Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] new EUDC backends for ecomplete, and mailabbrev (with ERT tests) Date: Mon, 28 Nov 2022 22:28:51 +0100 Message-ID: References: <8e9c60585677321e437a29215963a908@condition-alpha.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22734"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 28 22:29:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozlh0-0005j8-Na for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Nov 2022 22:29:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozlgT-0002in-4O; Mon, 28 Nov 2022 16:29:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozlgR-0002if-GD for emacs-devel@gnu.org; Mon, 28 Nov 2022 16:28:59 -0500 Original-Received: from smtprelay08.ispgateway.de ([134.119.228.109]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozlgQ-00047A-12 for emacs-devel@gnu.org; Mon, 28 Nov 2022 16:28:59 -0500 Original-Received: from [46.244.211.193] (helo=condition-alpha.com) by smtprelay08.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ozlgO-0000Es-1Z; Mon, 28 Nov 2022 22:28:56 +0100 In-Reply-To: X-Df-Sender: YWxleGFuZGVyLmFkb2xmQGNvbmRpdGlvbi1hbHBoYS5jb20= Received-SPF: pass client-ip=134.119.228.109; envelope-from=alexander.adolf@condition-alpha.com; helo=smtprelay08.ispgateway.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300690 Archived-At: Hello Thomas, Thomas Fitzsimmons writes: > [...] > Have you had a chance to look at Stefan's review of these new backends? > > It would be nice to include them before the emacs-29 branch is cut. > [...] Apologies for having been mute for quite a while. Life and other things got in the way. Appreciate your patience! I saw you pushed the two new backends, and made a couple of improvements. Many thanks for both! Looks all good to me. I think we can put a big green check-mark on this for now. Cool! What remains to be discussed - from my point of view - are the changes to message.el I was proposing. I guess at least some of the points raised by Eric Abrahamsen also fall under this, so I guess I should include both, you and Eric in my response to Stefan Monnier. Many thanks and cheers, --alexander