unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Max Mikhanosha <max.mikhanosha@protonmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Bugfix for utf-8 XTerm/MinTTY and (set-input-meta-mode t)
Date: Tue, 01 Jun 2021 18:10:53 +0000	[thread overview]
Message-ID: <cfEUsqXeHyryP2ESeHNWN-liLDYUwV_0UqQOU5zY36N7ZhgB2vLvTKE-iTvlXuDPmf-NgOS902qjDBdXAcfrZ_mJ5794mA3TkZ8hAXhyDw4=@protonmail.com> (raw)
In-Reply-To: <83czt5zd3r.fsf@gnu.org>

On Tuesday, June 1st, 2021 at 1:52 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> OK, but then it cannot really be anything but an opt-in behavior. And
> it cannot be hardcoded to depend on UTF-8 being the keyboard encoding,
> because if a user sets the keyboard encoding to be UTF-8 (something
> very popular these days), it doesn't mean the user gives up the
> ability to type Latin characters in the 128 -- 255 range.

I agree, and I don't really insist on my patch making it in, I understand that you're
reluctant to approve something thats in a hairy area of the code thats very few people
are touching. Reason I posted it, so that if other people having same problem as me
can find the patch easily, if someone is configured their Emacs with 8-bit-meta they
likely to have no problems applying the patch and compiling their own.

> Also, you show the results with input-meta-mode nil or t, but the
> default value is neither nil nor t. What is the effect of the patch
> when input-meta-mode is at its default value?

With default neither nil nor t (ie anything else), it sets kepyboard->meta_key to 2, which means 8-bit clean,
and than neither before my patch nor after my patch 8th bit is never looked at or stripped.

META parameter to keyboard->meta_key mapping in C is:
  NIL   => 0
  T     => 1
  other => 2

This can be trivially seen by grepping kepyboard.c for meta_key, all the if statements referencing meta_key
are either if (meta_key==1), and than if (meta_key != 2) for stripping the 8th bit.

Thus with default value of meta_key==2, there is no change to input decoding either before or after my patch



  reply	other threads:[~2021-06-01 18:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 16:19 Bugfix for utf-8 XTerm/MinTTY and (set-input-meta-mode t) Max Mikhanosha
2021-06-01 16:51 ` Eli Zaretskii
2021-06-01 17:28   ` Max Mikhanosha
2021-06-01 17:38     ` Eli Zaretskii
2021-06-01 18:01       ` Max Mikhanosha
2021-06-01 18:18         ` Eli Zaretskii
2021-06-01 18:35           ` Max Mikhanosha
2021-06-01 18:46             ` Eli Zaretskii
2021-06-02  9:22               ` Max Mikhanosha
2021-06-02 12:16                 ` Andreas Schwab
2021-06-03  5:42                   ` Max Mikhanosha
2021-06-05 14:20                     ` Eli Zaretskii
2021-06-01 17:29   ` Eli Zaretskii
2021-06-01 17:45     ` Max Mikhanosha
2021-06-01 17:52       ` Eli Zaretskii
2021-06-01 18:10         ` Max Mikhanosha [this message]
2021-06-01 17:04 ` Andreas Schwab
2021-06-01 17:36   ` Max Mikhanosha
2021-06-01 20:06 ` Stefan Monnier
2021-06-02 10:21   ` Max Mikhanosha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='cfEUsqXeHyryP2ESeHNWN-liLDYUwV_0UqQOU5zY36N7ZhgB2vLvTKE-iTvlXuDPmf-NgOS902qjDBdXAcfrZ_mJ5794mA3TkZ8hAXhyDw4=@protonmail.com' \
    --to=max.mikhanosha@protonmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).