From: Jim Porter <jporterbugs@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: master b811ad1: Improve behavior of 'electric-pair-mode' in 'cc-mode'
Date: Fri, 5 Nov 2021 22:29:34 -0700 [thread overview]
Message-ID: <cf16a2e7-69f4-8577-968f-07b152a1576a@gmail.com> (raw)
In-Reply-To: <87tugpap8p.fsf@gnus.org>
On 11/5/2021 9:21 PM, Lars Ingebrigtsen wrote:
> larsi@gnus.org (Lars Ingebrigtsen) writes:
>
>> commit b811ad15beeb4b96acb9d83b3a5770ef9f5fe172
>> Author: Jim Porter <jporterbugs@gmail.com>
>> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> I'm seeing some intermittent test failures after this change (I think),
> but it's frustratingly difficult to pin down. It only seems to happen
> when I say "make check-maybe", but not otherwise.
>
> Is anybody else seeing this?
I see this too, but as you say, it only happens with "make check-maybe"
(or when running electric-tests.el manually *after* "make check-maybe").
I can't reproduce it otherwise. If I check out the commit before this
patch, the issue goes away though.
I'm not totally clear on what check-maybe does, but it seems to create
some persistent state that causes the electric-tests to fail. The
failure I see is in `whitespace-chomping-dont-cross-comments' for
`c-mode', which would seem to point to my patch being the culprit, but
if I'm understanding what that function is testing, everything works as
it should when I try it out interactively.
- Jim
next prev parent reply other threads:[~2021-11-06 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211106002248.1025.75379@vcs0.savannah.gnu.org>
[not found] ` <20211106002249.E08DE20A22@vcs0.savannah.gnu.org>
2021-11-06 4:21 ` master b811ad1: Improve behavior of 'electric-pair-mode' in 'cc-mode' Lars Ingebrigtsen
2021-11-06 5:29 ` Jim Porter [this message]
2021-11-06 17:39 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf16a2e7-69f4-8577-968f-07b152a1576a@gmail.com \
--to=jporterbugs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).