From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master b811ad1: Improve behavior of 'electric-pair-mode' in 'cc-mode' Date: Fri, 5 Nov 2021 22:29:34 -0700 Message-ID: References: <20211106002248.1025.75379@vcs0.savannah.gnu.org> <20211106002249.E08DE20A22@vcs0.savannah.gnu.org> <87tugpap8p.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8694"; mail-complaints-to="usenet@ciao.gmane.io" To: Lars Ingebrigtsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 06 06:30:57 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjEI5-00026V-IP for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Nov 2021 06:30:57 +0100 Original-Received: from localhost ([::1]:37588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjEI4-0002SM-3I for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Nov 2021 01:30:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjEGo-0001hm-VN for emacs-devel@gnu.org; Sat, 06 Nov 2021 01:29:38 -0400 Original-Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:53182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjEGm-0007zp-VB for emacs-devel@gnu.org; Sat, 06 Nov 2021 01:29:38 -0400 Original-Received: by mail-pj1-x102e.google.com with SMTP id h24so3362413pjq.2 for ; Fri, 05 Nov 2021 22:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=TsmG5maUV2rqBCRA2nDFDgnBxmiZLiH2hwHtBq62Pag=; b=VdAWhYlNY1INygWFitpQQ4i/j9clv9pz44EeeWPe2VezVhgh3vdy/FRI4lVtxlXd+m oIDz7VArBSvEVIKuU7/TmWW/VSGa58GP6wQWNYcuQBBtvyCG2Uqz0DlGmo7hp/KNsSFt v59MW2XRTlZYhB7tVZM1be5Ey+nvqP1hDUcr92CSCGHCIpd5sIu4FOKUFuR2e3c3N7aQ tLtP4N+Df79As8hDoz4DKM6eW+emYzjFkKiSU6fWWEhgjTnjz4STbSU8kBLXjWrHp7cH c72QKtQglRqbq1bU6mu71d8jrvAQA8MaRQJCn61o4h6ld8vbnnIC19hJcW/RuGGn0/NX 1D8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TsmG5maUV2rqBCRA2nDFDgnBxmiZLiH2hwHtBq62Pag=; b=cCM+AEB+qNp73qgZt8jIYcWrKRs4D8x2id/nhJQrDIUu5FUYwxc4XZJSI+2aozk1vS tooFis2cXB36tQjlS49DQwULEGsuwMuvhzdse/GbuMWSDu3jYzLyYSnR7W6JtNeO7t+H saMmbdBBjdBGtxA0f0EzGC/7umauMHXCOi1Ai41kGEWo1MMGYPHCofPBBT+4V/2fCXaz y/jN6WotgqrLdWDcgRwsln4jNm8T3b3+oGNXBwVV9oZf5mYvykD02M7CYHrSBkty8tqa tzElco3F4FdWYyXEc8Xe6aW8HoFRPilCHaBn7Bf/g+cNnfpALAnl2+W2FRCnBBSF4+SO RroA== X-Gm-Message-State: AOAM5321qrac5HvPqLG7A5pWEHmkuyap70DJq30pNN/RzBrfgfGsyqrd +6e/YYkXQlIfcL1ZSRNEAz5ZBEW/gto= X-Google-Smtp-Source: ABdhPJxPJ4lBCCLfS6qTEvPH3ImJcXtPSwUg7gYzhMqWUtAtdyIlQkP00EF7/CLbY3sm3wvalNgupg== X-Received: by 2002:a17:90a:6886:: with SMTP id a6mr35711559pjd.78.1636176575253; Fri, 05 Nov 2021 22:29:35 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h6sm8781124pfi.174.2021.11.05.22.29.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 22:29:34 -0700 (PDT) In-Reply-To: <87tugpap8p.fsf@gnus.org> Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278843 Archived-At: On 11/5/2021 9:21 PM, Lars Ingebrigtsen wrote: > larsi@gnus.org (Lars Ingebrigtsen) writes: > >> commit b811ad15beeb4b96acb9d83b3a5770ef9f5fe172 >> Author: Jim Porter >> Commit: Lars Ingebrigtsen > > I'm seeing some intermittent test failures after this change (I think), > but it's frustratingly difficult to pin down. It only seems to happen > when I say "make check-maybe", but not otherwise. > > Is anybody else seeing this? I see this too, but as you say, it only happens with "make check-maybe" (or when running electric-tests.el manually *after* "make check-maybe"). I can't reproduce it otherwise. If I check out the commit before this patch, the issue goes away though. I'm not totally clear on what check-maybe does, but it seems to create some persistent state that causes the electric-tests to fail. The failure I see is in `whitespace-chomping-dont-cross-comments' for `c-mode', which would seem to point to my patch being the culprit, but if I'm understanding what that function is testing, everything works as it should when I try it out interactively. - Jim