unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: "Göktuğ Kayaalp" <self@gkayaalp.com>
Cc: eliz@gnu.org, emacs-devel@gnu.org
Subject: Re: Potential bug in the logic of rmail-select-summary
Date: Thu, 28 Jan 2021 10:42:34 +0100	[thread overview]
Message-ID: <bd9a6910-f508-bd3c-57f1-e1d94a5f5dc4@gmx.at> (raw)
In-Reply-To: <87ft2mhsl9.fsf@gkayaalp.com>

 > 	    ;; If pop-to-buffer did not use that window, delete that
 > 	    ;; window.  (This can happen if it uses another frame.)
 > 	    (if (not (eq sumbuf (window-buffer (frame-first-window))))
 > 		(delete-other-windows)))
 >
 > Here the condition is for some reason true somewhere in the call chain,
 > and I don’t really understand.

Do you mean to say that this part is also executed in the multiple
windows case despite of the

       (if (and (one-window-p)
	       pop-up-windows
	       (not pop-up-frames))

guard?

 > I think I’ll give up on this as what Rmail does with buffers in
 > intermediary steps of a command is fairly complex, and Rmail has many
 > assumptions about what’s where when.  Maybe later I’ll try make Rmail
 > call pop-to-buffer no more than strictly necessary.  Till then I’ll give
 > it it’s own frame and call it a day :)

I'm afraid that Rmail is just not amenable to customizations via
'display-buffer'.  It probably would have to be rewritten from scratch
for that purpose.

martin




      reply	other threads:[~2021-01-28  9:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 12:23 Potential bug in the logic of rmail-select-summary Göktuğ Kayaalp
2021-01-19 14:50 ` Eli Zaretskii
2021-01-19 17:14   ` Göktuğ Kayaalp
2021-01-19 18:33     ` Eli Zaretskii
2021-01-19 19:04       ` martin rudalics
2021-01-20 14:09         ` Göktuğ Kayaalp
2021-01-20 16:51           ` martin rudalics
2021-01-27 23:23             ` Göktuğ Kayaalp
2021-01-28  9:42               ` martin rudalics [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd9a6910-f508-bd3c-57f1-e1d94a5f5dc4@gmx.at \
    --to=rudalics@gmx.at \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=self@gkayaalp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).