unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Göktuğ Kayaalp" <self@gkayaalp.com>,
	"martin rudalics" <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: Potential bug in the logic of rmail-select-summary
Date: Tue, 19 Jan 2021 20:33:11 +0200	[thread overview]
Message-ID: <83wnw87p5k.fsf@gnu.org> (raw)
In-Reply-To: <8735ywyhli.fsf@gkayaalp.com> (message from Göktuğ Kayaalp on Tue, 19 Jan 2021 20:14:17 +0300)

> From: Göktuğ Kayaalp <self@gkayaalp.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 19 Jan 2021 20:14:17 +0300
> 
>  display-buffer-alist
>  '(("\\*Quail Completions" . (display-buffer-in-side-window))
>    ("\\*.*Completions\\*" . (display-buffer-in-side-window . ((side . bottom))))
>    ("\\*Help\\*" . (display-buffer-reuse-window))
>    ("Checkdoc" . (display-buffer-pop-up-window))
>    ("Calendar" . (display-buffer-in-side-window . ((side . bottom))))
>    ("help\\[R\\]" . (display-buffer-pop-up-window))
>    (".*" . (display-buffer-same-window)))
> 
> When I commented out that last line it worked.  FWIW, I added the
> following advice which seems to help:
> 
> (define-advice rmail-show-message
>     (:around (fn &rest args) inhibit-display-buffer-alist)
>   (let ((display-buffer-alist nil))
>     (apply fn args)))
> 
> Is this an expected interaction or a bug?

Well, you in fact asked Emacs to use display-buffer-same-window for
displaying any buffer except the few you explicitly exempted, no?
Then I think it's what you asked for.

> AFAIU rmail-pop-to-buffer could use some form of display-buffer-* to
> avoid going through display-buffer-alist.

Yes, but I'm  not sure we should prevent users from customizing the
way Rmail buffers are displayed.

Perhaps Martin could comment on this?



  reply	other threads:[~2021-01-19 18:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 12:23 Potential bug in the logic of rmail-select-summary Göktuğ Kayaalp
2021-01-19 14:50 ` Eli Zaretskii
2021-01-19 17:14   ` Göktuğ Kayaalp
2021-01-19 18:33     ` Eli Zaretskii [this message]
2021-01-19 19:04       ` martin rudalics
2021-01-20 14:09         ` Göktuğ Kayaalp
2021-01-20 16:51           ` martin rudalics
2021-01-27 23:23             ` Göktuğ Kayaalp
2021-01-28  9:42               ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wnw87p5k.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    --cc=self@gkayaalp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).