* PATCH: csharp-mode - improve fontification of typeof() expressions
@ 2022-11-25 20:02 Jostein Kjønigsen
2022-11-26 23:11 ` Yuan Fu
0 siblings, 1 reply; 2+ messages in thread
From: Jostein Kjønigsen @ 2022-11-25 20:02 UTC (permalink / raw)
To: Ergus via Emacs development discussions., Yuan Fu
[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]
Hey everyone.
As I promised in my earlier mail on this list, I'd still love to keep
contributing.
As such, here's a small patch which improves fontification of C#
typeof() expressions. Is it OK as is, or does anyone see the need for
anything additional to get this merged?
--
Kind regards
*Jostein Kjønigsen*
jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no <https://jostein.kjønigsen.no>
[-- Attachment #1.2: Type: text/html, Size: 890 bytes --]
[-- Attachment #2: 0001-Csharp-Correctly-fontify-types-in-typeof-expression.patch --]
[-- Type: text/x-patch, Size: 960 bytes --]
From 7280c25f0753ed18a1d74e64b26e80e038e29739 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= <jostein@kjonigsen.net>
Date: Fri, 25 Nov 2022 20:15:06 +0100
Subject: [PATCH] Csharp: Correctly fontify types in typeof() expression.
---
lisp/progmodes/csharp-mode.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
index af3a4d86da2..11fa951048e 100644
--- a/lisp/progmodes/csharp-mode.el
+++ b/lisp/progmodes/csharp-mode.el
@@ -806,7 +806,8 @@ csharp-ts-mode--font-lock-settings
(cast_expression (identifier) @font-lock-type-face)
["operator"] @font-lock-type-face
(type_parameter_constraints_clause
- target: (identifier) @font-lock-type-face))
+ target: (identifier) @font-lock-type-face)
+ (type_of_expression (identifier) @font-lock-type-face))
:language 'c-sharp
:feature 'definition
:override t
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: PATCH: csharp-mode - improve fontification of typeof() expressions
2022-11-25 20:02 PATCH: csharp-mode - improve fontification of typeof() expressions Jostein Kjønigsen
@ 2022-11-26 23:11 ` Yuan Fu
0 siblings, 0 replies; 2+ messages in thread
From: Yuan Fu @ 2022-11-26 23:11 UTC (permalink / raw)
To: jostein; +Cc: Ergus via Emacs development discussions.
> On Nov 25, 2022, at 12:02 PM, Jostein Kjønigsen <jostein@secure.kjonigsen.net> wrote:
>
> Hey everyone.
>
> As I promised in my earlier mail on this list, I'd still love to keep contributing.
>
> As such, here's a small patch which improves fontification of C# typeof() expressions. Is it OK as is, or does anyone see the need for anything additional to get this merged?
>
Thanks Jostein, I applied your patch.
Yuan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-26 23:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 20:02 PATCH: csharp-mode - improve fontification of typeof() expressions Jostein Kjønigsen
2022-11-26 23:11 ` Yuan Fu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).