mm-util.el question

mm-util.el question

[Miles Bader]

In merging some of Stefan's Gnus changes from the Emacs tree into the Gnus
trunk, I ran across this change, which I'm not sure about, in mm-util.el:

@@ -75,4 +93,5 @@
      (string-as-multibyte . identity)
+     (string-to-multibyte . mm-string-as-multibyte)
      (multibyte-string-p . ignore)
      ;; It is not a MIME function, but some MIME functions use it.
      (make-temp-file . (lambda (prefix &optional dir-flag)

The Gnus trunk already has an entry for `string-to-multibyte':

     (string-to-multibyte
      . (lambda (string)
	  "Return a multibyte string with the same individual chars as string."
	  (mapconcat
	   (lambda (ch) (mm-string-as-multibyte (char-to-string ch)))
	   string "")))

So is the more complicated Gnus version necessary, or would Stefan's version
(making `mm-string-to-multibyte' the same as `mm-string-as-multibyte') work
as well?

Thanks,

-Miles
-- 
Somebody has to do something, and it's just incredibly pathetic that it
has to be us.  -- Jerry Garcia

Re: mm-util.el question

[Katsumi Yamaoka]

>>>>> In <61hdicykk7.fsf@fencepost.gnu.org> Miles Bader wrote:

> In merging some of Stefan's Gnus changes from the Emacs tree into the Gnus
> trunk, I ran across this change, which I'm not sure about, in mm-util.el:

> @@ -75,4 +93,5 @@
>       (string-as-multibyte . identity)
> +     (string-to-multibyte . mm-string-as-multibyte)
>       (multibyte-string-p . ignore)
>       ;; It is not a MIME function, but some MIME functions use it.
>       (make-temp-file . (lambda (prefix &optional dir-flag)

It cannot achieve the purpose in Emacs 21.  Currently, it is
used in `gnus-mime-inline-part' in the Gnus trunk to display
binary data *as is*.  For example:

(let ((string (string-as-unibyte "\xf8\xf9\xfa\xfb\xfc\xfd\xfe\xff"))
      (buffer (get-buffer-create "*testing*")))
  (pop-to-buffer buffer)
  (erase-buffer)
  (set-buffer-multibyte t)
  (insert (mm-string-to-multibyte string)))

The `string' have to be shown as `\370\371\372\373\374\375\376\377',
not as some *characters*.

> The Gnus trunk already has an entry for `string-to-multibyte':

>      (string-to-multibyte
>       . (lambda (string)
> 	  "Return a multibyte string with the same individual chars as string."
> 	  (mapconcat
> 	   (lambda (ch) (mm-string-as-multibyte (char-to-string ch)))
> 	   string "")))

> So is the more complicated Gnus version necessary, or would Stefan's version
> (making `mm-string-to-multibyte' the same as `mm-string-as-multibyte') work
> as well?

The latter seems to me to be profitable for all.

Re: mm-util.el question

[Katsumi Yamaoka]

>>>>> In <b9yekdgsuvz.fsf@jpl.org> Katsumi Yamaoka wrote:

> (let ((string (string-as-unibyte "\xf8\xf9\xfa\xfb\xfc\xfd\xfe\xff"))
>       (buffer (get-buffer-create "*testing*")))
>   (pop-to-buffer buffer)
>   (erase-buffer)
>   (set-buffer-multibyte t)
>   (insert (mm-string-to-multibyte string)))

> The `string' have to be shown as `\370\371\372\373\374\375\376\377',
> not as some *characters*.

Sorry, that was not appropriate.  Here's a new one.

(let ((string "\214\352\227\245\346")
      (buffer (get-buffer-create "*testing*")))
  (pop-to-buffer buffer)
  (erase-buffer)
  (set-buffer-multibyte t)
  (insert (mm-string-to-multibyte string)))

Re: mm-util.el question

[Miles Bader]

So does that mean the Gnus-trunk version should be used in 5.10
instead of Stefan's version (and I suppose 5.11 for ease of sharing,
though perhaps not by necessity)?

Thanks,

-Miles
-- 
Do not taunt Happy Fun Ball.

Re: mm-util.el question

[Katsumi Yamaoka]

>>>>> In <fc339e4a05041121115214c115@mail.gmail.com> Miles Bader wrote:

> So does that mean the Gnus-trunk version should be used in 5.10
> instead of Stefan's version (and I suppose 5.11 for ease of sharing,
> though perhaps not by necessity)?

I think so since string-as-multibyte cannot be a substitution
for string-to-multibyte AFAIK.

Regards,

Re: mm-util.el question

[Katsumi Yamaoka]

>>>>> In <E1DLZyx-00057P-00@quimby.gnus.org> Miles Bader wrote:

>     Date: Wednesday, April 13, 2005 @ 07:00:07
>   Author: cvs
>     Path: /usr/local/cvsroot/gnus/lisp
>      Tag: v5-10

> Modified: ChangeLog mm-util.el

> Revision: miles@gnu.org--gnu-2005/gnus--rel--5.10--patch-64

> (mm-string-to-multibyte): Use Gnus trunk definition.

Thanks for your work.  Subsequently, I've changed gnus-art.el
and qp.el in the v5-10 branch, and qp.el in the Gnus trunk so
that they may use mm-string-to-multibyte.

Regards,