From: Pierre-Yves Luyten <py@luyten.fr>
To: emacs-devel@gnu.org
Cc: Karl Fogel <kfogel@red-bean.com>, Drew Adams <drew.adams@oracle.com>
Subject: Re: [PATCH] open bookmark in other frame
Date: Thu, 11 Oct 2018 13:30:23 +0200 [thread overview]
Message-ID: <b76c21007dcc2f0a56055d71555128e7@luyten.fr> (raw)
In-Reply-To: <87zhvl0x2y.fsf@red-bean.com>
Le 2018-10-11 09:19, Karl Fogel a écrit :
> Drew Adams <drew.adams@oracle.com> writes:
>> My suggestions in this regard, FWIW:
>>
>> 1. Don't use `view-buffer-other-frame'.
>> (...)
>
> Agreed -- there's no reason it should be read-only. Jumping to a
> bookmark doesn't normally cause the destination to be read-only, so
> there's no reason that should happen just because we're in a new
> frame.
noted i will review this
>
>> 2. Don't use `F' as the key binding in the bookmark-list buffer.
>> `F' is more often used for files than for frames. Maybe use `5'.
>>
>> (...)
>
> I don't have a strong opinion here, but my fingers also lean slightly
> toward "5" because of `C-x 5 b', for what it's worth.
>
now you suggest 5 it looks like a nice way to go.
I will review patch in the upcoming days to solve these two points and
improve commit message
Regards
Pierre-Yves
next prev parent reply other threads:[~2018-10-11 11:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:14 [PATCH] open bookmark in other frame Pierre-Yves Luyten
2018-10-10 20:16 ` Marcin Borkowski
2018-10-10 21:35 ` Karl Fogel
2018-10-11 11:42 ` Pierre-Yves Luyten
2018-10-10 22:06 ` Drew Adams
2018-10-11 7:19 ` Karl Fogel
2018-10-11 11:30 ` Pierre-Yves Luyten [this message]
2018-10-11 13:35 ` Drew Adams
2018-10-11 21:50 ` Pierre-Yves Luyten
2018-10-11 22:04 ` Drew Adams
2018-10-12 19:45 ` Pierre-Yves Luyten
2018-10-12 21:23 ` Karl Fogel
2018-10-14 19:45 ` Pierre-Yves Luyten
2018-10-16 2:09 ` Karl Fogel
2018-10-16 9:51 ` Pierre-Yves Luyten
2018-10-16 2:10 ` Karl Fogel
2018-11-02 18:55 ` Karl Fogel
2018-11-04 21:10 ` Pierre-Yves Luyten
2018-11-09 0:54 ` Karl Fogel
2018-10-13 15:04 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b76c21007dcc2f0a56055d71555128e7@luyten.fr \
--to=py@luyten.fr \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).