From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pierre-Yves Luyten Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] open bookmark in other frame Date: Thu, 11 Oct 2018 13:30:23 +0200 Message-ID: References: <9d4a9ab3-d802-447e-3c74-81373b7e6101@luyten.fr> <87zhvl0x2y.fsf@red-bean.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1539257638 14138 195.159.176.226 (11 Oct 2018 11:33:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Oct 2018 11:33:58 +0000 (UTC) User-Agent: Roundcube Webmail/1.3.7 Cc: Karl Fogel , Drew Adams To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 11 13:33:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAZE1-0003ZT-MN for ged-emacs-devel@m.gmane.org; Thu, 11 Oct 2018 13:33:53 +0200 Original-Received: from localhost ([::1]:33627 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAZG8-0006v9-1S for ged-emacs-devel@m.gmane.org; Thu, 11 Oct 2018 07:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAZAq-0002mG-71 for emacs-devel@gnu.org; Thu, 11 Oct 2018 07:30:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAZAk-0002mX-1c for emacs-devel@gnu.org; Thu, 11 Oct 2018 07:30:36 -0400 Original-Received: from 2.mo69.mail-out.ovh.net ([178.33.251.80]:53759) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gAZAj-0002kd-Aw for emacs-devel@gnu.org; Thu, 11 Oct 2018 07:30:29 -0400 Original-Received: from player157.ha.ovh.net (unknown [10.109.160.230]) by mo69.mail-out.ovh.net (Postfix) with ESMTP id BFDBD3050B for ; Thu, 11 Oct 2018 13:30:26 +0200 (CEST) Original-Received: from RCM-web4.webmail.mail.ovh.net (unknown [194.206.55.11]) (Authenticated sender: py@luyten.fr) by player157.ha.ovh.net (Postfix) with ESMTPSA id 1BEB710009D; Thu, 11 Oct 2018 13:30:23 +0200 (CEST) Original-Received: from [194.206.55.11] via [194.206.55.11] by mail.ovh.net with HTTP (HTTP/1.1 POST); Thu, 11 Oct 2018 13:30:23 +0200 In-Reply-To: <87zhvl0x2y.fsf@red-bean.com> X-Sender: py@luyten.fr X-Originating-IP: 194.206.55.11 X-Webmail-UserID: py@luyten.fr X-Ovh-Tracer-Id: 3770075838231261414 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudekgdefkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 178.33.251.80 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230334 Archived-At: Le 2018-10-11 09:19, Karl Fogel a =C3=A9crit=C2=A0: > Drew Adams writes: >> My suggestions in this regard, FWIW: >>=20 >> 1. Don't use `view-buffer-other-frame'. >> (...) >=20 > Agreed -- there's no reason it should be read-only. Jumping to a > bookmark doesn't normally cause the destination to be read-only, so > there's no reason that should happen just because we're in a new > frame. noted i will review this >=20 >> 2. Don't use `F' as the key binding in the bookmark-list buffer. >> `F' is more often used for files than for frames. Maybe use `5'. >>=20 >> (...) >=20 > I don't have a strong opinion here, but my fingers also lean slightly > toward "5" because of `C-x 5 b', for what it's worth. >=20 now you suggest 5 it looks like a nice way to go. I will review patch in the upcoming days to solve these two points and=20 improve commit message Regards Pierre-Yves