unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* emacs-lock-unlockable-modes should default to nil
@ 2018-06-30  7:40 Tino Calancha
  2018-07-07  9:54 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Tino Calancha @ 2018-06-30  7:40 UTC (permalink / raw)
  To: Emacs developers; +Cc: Juanma Barranquero, Tino Calancha


Dear Emacs,

I see the comment in the source code: the current value is due
to compatibility with older versions.

I was bitten today with this.  I first thought it was a
bug; then, I realized is the result of a default setting.

Many users would assume that their buffers are secured once they
turn on this minor-mode, overlooking that this option does exist.
I think the value nil is a better default to support such expectations.

Tino



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: emacs-lock-unlockable-modes should default to nil
  2018-06-30  7:40 emacs-lock-unlockable-modes should default to nil Tino Calancha
@ 2018-07-07  9:54 ` Eli Zaretskii
  2018-07-07 10:23   ` Tino Calancha
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2018-07-07  9:54 UTC (permalink / raw)
  To: Tino Calancha; +Cc: lekktu, emacs-devel

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sat, 30 Jun 2018 16:40:45 +0900 (JST)
> Cc: Juanma Barranquero <lekktu@gmail.com>,
> 	Tino Calancha <tino.calancha@gmail.com>
> 
> I see the comment in the source code: the current value is due
> to compatibility with older versions.
> 
> I was bitten today with this.  I first thought it was a
> bug; then, I realized is the result of a default setting.
> 
> Many users would assume that their buffers are secured once they
> turn on this minor-mode, overlooking that this option does exist.
> I think the value nil is a better default to support such expectations.

The current value was set 7 years ago and released in Emacs 24.1 6
years ago.  I'm not sure this is long enough for such a radical
change.

In any case, it is not a good situation that the doc string of
emacs-lock-mode doesn't even mention emacs-lock-unlockable-modes, so
users have no hope of learning about this variable's critical
importance unless they read the code.  So as the first step towards
perhaps changing the default in the future, I added references to this
variable to relevant doc strings.

Thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: emacs-lock-unlockable-modes should default to nil
  2018-07-07  9:54 ` Eli Zaretskii
@ 2018-07-07 10:23   ` Tino Calancha
  0 siblings, 0 replies; 3+ messages in thread
From: Tino Calancha @ 2018-07-07 10:23 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: lekktu, emacs-devel, Tino Calancha



On Sat, 7 Jul 2018, Eli Zaretskii wrote:

> In any case, it is not a good situation that the doc string of
> emacs-lock-mode doesn't even mention emacs-lock-unlockable-modes, so
> users have no hope of learning about this variable's critical
> importance unless they read the code.  So as the first step towards
> perhaps changing the default in the future, I added references to this
> variable to relevant doc strings.

Good improvement: favor discoverability of such option.
Thank you




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-07 10:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-30  7:40 emacs-lock-unlockable-modes should default to nil Tino Calancha
2018-07-07  9:54 ` Eli Zaretskii
2018-07-07 10:23   ` Tino Calancha

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).