Re: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search.

Re: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search.

[Lars Magne Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:
>
>>> I'm not sure that that's a useful eww mode
>>> command, but it might be a useful global command...
>>
>> Then, how about delete the key map and include the eww-search-region?
>> I want to know how much eww should provide its utilities like this function.
>
> Emacs is in a feature freeze, but I think it sounds like a very useful
> thing to be able to just set a point and mark in any buffer, hit
> `M-s M-s', and then be presented with the eww search results.  Others
> will have to comment on the keystroke, though.

Does anybody have an opinion on this feature?  I think it sounds useful,
but I have no idea what global keystroke we would want to bind this to.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search.

[Stefan Monnier]

> Does anybody have an opinion on this feature?  I think it sounds useful,
> but I have no idea what global keystroke we would want to bind this to.

We have the M-s prefix specifically for search-related commands, so
there's a lot of key-binding room.


        Stefan

RE: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search.

[Drew Adams]

> > Does anybody have an opinion on this feature?  I think it sounds
> > useful,
> > but I have no idea what global keystroke we would want to bind
> > this to.
> 
> We have the M-s prefix specifically for search-related commands, so
> there's a lot of key-binding room.

I have no opinion on the feature.  But it should not be named `*-region-search'.  It does not search the region (IIUC).  It searches for the selected text.

RE: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search.

[Drew Adams]

> it should not be named `*- region-search'.  It does not
> search the region (IIUC). It searches for the selected text.

Again, please rename the command.  The name is misleading.
The command neither searches the region nor searches for the
region (which would anyway be meaningless, from point).
It searches a buffer (I assume) for the text in the region.

People checking command names (via apropos commands or
completion matching, for example) looking for commands
that do something to the region can stumble on this.
(And people looking for a command that searches for the
selected text are unlikely to find it.)

A guess is that this was named by someone for whom
English is not the first language.  "Search X" is not
the same as "search for X".

Re: bug#16258: 24.3.50; [PATCH] eww: Add new function of region-search.

[Lars Magne Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

>> it should not be named `*- region-search'.  It does not
>> search the region (IIUC). It searches for the selected text.
>
> Again, please rename the command.  The name is misleading.

It's not called that.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no