From: Ken Raeburn <raeburn@raeburn.org>
Cc: emacs-devel@gnu.org
Subject: Re: optimization for pop movemail
Date: Tue, 5 Jul 2005 03:00:42 -0400 [thread overview]
Message-ID: <a05cd0f8aa9ee320ed5a4f305146a721@raeburn.org> (raw)
In-Reply-To: <E1DpU7U-0004to-1y@fencepost.gnu.org>
> + if (line == pop_error && strlen (line) < sizeof (pop_error) - 5)
>
> That code is a horrible kludge.
Yeah, true... even worse than the existing kludge of using the
error-return buffer, sometimes, to hold the message to be sent out.
> It would be better to copy the string
> to a temporary buffer and add the \r\n there. You could allocate it
> with alloca. That is clean, and you could do it unconditionally.
Okay, will do.
> This may as well be fixed now--why wait?
Wasn't sure if we were very close to a release or something. I haven't
seen any mail indicating it, but I have seen mail talking about
freezing some kinds of changes, and I can't quite keep up on all the
list mail so I might've missed something if it was under a subject line
that looked uninteresting to me. And it's debatable whether this is a
bug fix or just a minor efficiency issue.
I'll revise the patch and check it in, should be sometime this week...
Ken
next prev parent reply other threads:[~2005-07-05 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-03 23:01 optimization for pop movemail Ken Raeburn
2005-07-04 16:48 ` Richard M. Stallman
2005-07-05 7:00 ` Ken Raeburn [this message]
2005-07-05 19:11 ` Richard M. Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a05cd0f8aa9ee320ed5a4f305146a721@raeburn.org \
--to=raeburn@raeburn.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).