From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Raeburn Newsgroups: gmane.emacs.devel Subject: Re: optimization for pop movemail Date: Tue, 5 Jul 2005 03:00:42 -0400 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v622) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1120547164 12396 80.91.229.2 (5 Jul 2005 07:06:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 5 Jul 2005 07:06:04 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 05 09:05:58 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DphV9-00078b-8h for ged-emacs-devel@m.gmane.org; Tue, 05 Jul 2005 09:05:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DphWO-0000GD-Fm for ged-emacs-devel@m.gmane.org; Tue, 05 Jul 2005 03:07:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DphTg-0007AQ-4C for emacs-devel@gnu.org; Tue, 05 Jul 2005 03:04:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DphTd-000793-NQ for emacs-devel@gnu.org; Tue, 05 Jul 2005 03:04:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DphTd-000790-CJ for emacs-devel@gnu.org; Tue, 05 Jul 2005 03:04:17 -0400 Original-Received: from [207.172.4.63] (helo=smtp04.mrf.mail.rcn.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DphWC-00020f-5E; Tue, 05 Jul 2005 03:06:56 -0400 Original-Received: from 65-78-24-4.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com (HELO raeburn.org) (65.78.24.4) by smtp04.mrf.mail.rcn.net with ESMTP; 05 Jul 2005 03:00:26 -0400 X-IronPort-AV: i="3.93,259,1115006400"; d="scan'208"; a="54993772:sNHT21267028" Original-Received: from [18.101.0.226] (laptop.raeburn.org [18.101.0.226]) by raeburn.org (8.12.11/8.12.11) with ESMTP id j6570P1I006137; Tue, 5 Jul 2005 03:00:25 -0400 (EDT) In-Reply-To: Original-To: rms@gnu.org X-Mailer: Apple Mail (2.622) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40397 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40397 > + if (line == pop_error && strlen (line) < sizeof (pop_error) - 5) > > That code is a horrible kludge. Yeah, true... even worse than the existing kludge of using the error-return buffer, sometimes, to hold the message to be sent out. > It would be better to copy the string > to a temporary buffer and add the \r\n there. You could allocate it > with alloca. That is clean, and you could do it unconditionally. Okay, will do. > This may as well be fixed now--why wait? Wasn't sure if we were very close to a release or something. I haven't seen any mail indicating it, but I have seen mail talking about freezing some kinds of changes, and I can't quite keep up on all the list mail so I might've missed something if it was under a subject line that looked uninteresting to me. And it's debatable whether this is a bug fix or just a minor efficiency issue. I'll revise the patch and check it in, should be sometime this week... Ken