From: Alan Mackenzie <acm@muc.de>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: master 0a57dfcff8d 2/2: Ensure that specbind arg is always bare symbol, and drop check
Date: Sat, 20 Apr 2024 12:34:30 +0000 [thread overview]
Message-ID: <ZiO2VnMhcC5egSrB@ACM> (raw)
In-Reply-To: <62CCA765-3274-40E3-8A8D-FB2AF6E83CA2@gmail.com>
Hello, Mattias.
On Sat, Apr 20, 2024 at 09:29:24 +0200, Mattias Engdegård wrote:
> 20 apr. 2024 kl. 03.48 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
> > Maybe I'm missing some context, but IIRC we had concluded that if sympos
> > reach actual evaluation it's a sign of a bug upstream.
> I certainly wouldn't mind using CHECK_BARE_SYMBOL_P but since the old
> code tolerated sympos as variable names in interpreted variable
> bindings, I just kept the semantics unchanged. This change was just a
> cycle shave.
How does that address Stefan's question? It seems to me it doesn't at
all.
Have you changed _any_ of the semantics, here?
It seems to me that when symbols_with_pos_enabled is non-nil, SWPs are
intended to be used as symbols, so provided the replacement is done only
in that case (which seems to be so), then the code will carry on working
according to its design.
--
Alan Mackenzie (Nuremberg, Germany).
prev parent reply other threads:[~2024-04-20 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171344154944.7691.6557554183289684123@vcs2.savannah.gnu.org>
[not found] ` <20240418115910.3182CC1FB65@vcs2.savannah.gnu.org>
2024-04-20 1:48 ` master 0a57dfcff8d 2/2: Ensure that specbind arg is always bare symbol, and drop check Stefan Monnier
2024-04-20 7:29 ` Mattias Engdegård
2024-04-20 12:34 ` Alan Mackenzie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiO2VnMhcC5egSrB@ACM \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).