From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master 0a57dfcff8d 2/2: Ensure that specbind arg is always bare symbol, and drop check Date: Sat, 20 Apr 2024 12:34:30 +0000 Message-ID: References: <171344154944.7691.6557554183289684123@vcs2.savannah.gnu.org> <20240418115910.3182CC1FB65@vcs2.savannah.gnu.org> <62CCA765-3274-40E3-8A8D-FB2AF6E83CA2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3543"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 20 14:35:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ry9wA-0000jq-4y for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Apr 2024 14:35:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ry9vR-0004sf-Fq; Sat, 20 Apr 2024 08:34:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ry9vP-0004sW-N9 for emacs-devel@gnu.org; Sat, 20 Apr 2024 08:34:35 -0400 Original-Received: from mail.muc.de ([193.149.48.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ry9vN-0002rI-Sv for emacs-devel@gnu.org; Sat, 20 Apr 2024 08:34:35 -0400 Original-Received: (qmail 96960 invoked by uid 3782); 20 Apr 2024 14:34:31 +0200 Original-Received: from muc.de (pd953a265.dip0.t-ipconnect.de [217.83.162.101]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 20 Apr 2024 14:34:30 +0200 Original-Received: (qmail 7187 invoked by uid 1000); 20 Apr 2024 12:34:30 -0000 Content-Disposition: inline In-Reply-To: <62CCA765-3274-40E3-8A8D-FB2AF6E83CA2@gmail.com> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.3; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317874 Archived-At: Hello, Mattias. On Sat, Apr 20, 2024 at 09:29:24 +0200, Mattias Engdegård wrote: > 20 apr. 2024 kl. 03.48 skrev Stefan Monnier : > > Maybe I'm missing some context, but IIRC we had concluded that if sympos > > reach actual evaluation it's a sign of a bug upstream. > I certainly wouldn't mind using CHECK_BARE_SYMBOL_P but since the old > code tolerated sympos as variable names in interpreted variable > bindings, I just kept the semantics unchanged. This change was just a > cycle shave. How does that address Stefan's question? It seems to me it doesn't at all. Have you changed _any_ of the semantics, here? It seems to me that when symbols_with_pos_enabled is non-nil, SWPs are intended to be used as symbols, so provided the replacement is done only in that case (which seems to be so), then the code will carry on working according to its design. -- Alan Mackenzie (Nuremberg, Germany).