unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
Cc: emacs-devel@gnu.org
Subject: Re: Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes
Date: Sat, 30 Sep 2023 14:36:53 +0000	[thread overview]
Message-ID: <ZRgyhbBQYBtbtHbh@ACM> (raw)
In-Reply-To: <6cb93006-19ac-1ef5-a132-481e9c9791e9@vodafonemail.de>

Hello, Jens.

On Sat, Sep 30, 2023 at 11:20:04 +0200, Jens Schmidt wrote:
> Seems commit 01229fe0096e936ea8f4fad0d64967671c4b1892 has
> introduced a regression.  The following fixes it:


> diff --git a/test/lisp/emacs-lisp/cl-print-tests.el b/test/lisp/emacs-lisp/cl-print-tests.el
> index 3073a42e39d..3aac161b344 100644
> --- a/test/lisp/emacs-lisp/cl-print-tests.el
> +++ b/test/lisp/emacs-lisp/cl-print-tests.el
> @@ -60,7 +60,8 @@ cl-print-tests-ellipsis-vector
 
>  (ert-deftest cl-print-tests-ellipsis-string ()
>    "Ellipsis expansion works in strings."
> -  (let ((print-length 4)
> +  (let ((cl-print-string-length 4)
> +        (print-length 4)
>          (print-level 3))
>      (cl-print-tests-check-ellipsis-expansion
>       "abcdefg" "\"abcd...\"" "efg")


> But the fact that one has to bind `cl-print-string-length' *and*
> `print-length' could indicate that the commit probably is not
> "complete" yet.  In the sense that more occurrences of `print-length'
> need to be modified in cl-print.el.

I simply forgot to commit the change to cl-print-tests.el, sorry.  I've
committed them now, so the tests should now run success-free again.

-- 
Alan Mackenzie (Nuremberg, Germany).



      reply	other threads:[~2023-09-30 14:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30  9:20 Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes Jens Schmidt
2023-09-30 14:36 ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRgyhbBQYBtbtHbh@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=jschmidt4gnu@vodafonemail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).