From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes Date: Sat, 30 Sep 2023 14:36:53 +0000 Message-ID: References: <6cb93006-19ac-1ef5-a132-481e9c9791e9@vodafonemail.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15274"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jens Schmidt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 30 16:37:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmb60-0003m2-3E for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Sep 2023 16:37:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmb5b-0003lO-Nm; Sat, 30 Sep 2023 10:37:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmb5X-0003lE-Pq for emacs-devel@gnu.org; Sat, 30 Sep 2023 10:37:00 -0400 Original-Received: from mail.muc.de ([193.149.48.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmb5V-0006tn-MA for emacs-devel@gnu.org; Sat, 30 Sep 2023 10:36:59 -0400 Original-Received: (qmail 70985 invoked by uid 3782); 30 Sep 2023 16:36:55 +0200 Original-Received: from acm.muc.de (pd953adb3.dip0.t-ipconnect.de [217.83.173.179]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 30 Sep 2023 16:36:54 +0200 Original-Received: (qmail 15415 invoked by uid 1000); 30 Sep 2023 14:36:53 -0000 Content-Disposition: inline In-Reply-To: <6cb93006-19ac-1ef5-a132-481e9c9791e9@vodafonemail.de> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.3; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311210 Archived-At: Hello, Jens. On Sat, Sep 30, 2023 at 11:20:04 +0200, Jens Schmidt wrote: > Seems commit 01229fe0096e936ea8f4fad0d64967671c4b1892 has > introduced a regression. The following fixes it: > diff --git a/test/lisp/emacs-lisp/cl-print-tests.el b/test/lisp/emacs-lisp/cl-print-tests.el > index 3073a42e39d..3aac161b344 100644 > --- a/test/lisp/emacs-lisp/cl-print-tests.el > +++ b/test/lisp/emacs-lisp/cl-print-tests.el > @@ -60,7 +60,8 @@ cl-print-tests-ellipsis-vector > (ert-deftest cl-print-tests-ellipsis-string () > "Ellipsis expansion works in strings." > - (let ((print-length 4) > + (let ((cl-print-string-length 4) > + (print-length 4) > (print-level 3)) > (cl-print-tests-check-ellipsis-expansion > "abcdefg" "\"abcd...\"" "efg") > But the fact that one has to bind `cl-print-string-length' *and* > `print-length' could indicate that the commit probably is not > "complete" yet. In the sense that more occurrences of `print-length' > need to be modified in cl-print.el. I simply forgot to commit the change to cl-print-tests.el, sorry. I've committed them now, so the tests should now run success-free again. -- Alan Mackenzie (Nuremberg, Germany).