* Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d
@ 2023-09-21 6:29 Pedro Andres Aranda Gutierrez
2023-09-21 8:46 ` Gerd Möllmann
0 siblings, 1 reply; 9+ messages in thread
From: Pedro Andres Aranda Gutierrez @ 2023-09-21 6:29 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
Hi
reading removed FIXME in the second hunk:
# FIXME: Don't install the dump file into the app bundle when
# self-contained install is disabled.
I understand that we should install if self-contained is enabled.
However, I see
+ifeq (${ns_self_contained},no)
Shouldn't that read as
+ifeq (${ns_self_contained},yes)
I'm confused...
/PA
--
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler
Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet
[-- Attachment #2: Type: text/html, Size: 3016 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d
2023-09-21 6:29 Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d Pedro Andres Aranda Gutierrez
@ 2023-09-21 8:46 ` Gerd Möllmann
2023-09-21 9:59 ` Pedro Andres Aranda Gutierrez
2023-09-21 16:50 ` Alan Third
0 siblings, 2 replies; 9+ messages in thread
From: Gerd Möllmann @ 2023-09-21 8:46 UTC (permalink / raw)
To: Pedro Andres Aranda Gutierrez, emacs-devel
On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
> Hi
>
> reading removed FIXME in the second hunk:
>
> # FIXME: Don't install the dump file into the app bundle when
> # self-contained install is disabled.
>
> I understand that we should install if self-contained is enabled.
>
> However, I see
>
> +ifeq (${ns_self_contained},no)
>
> Shouldn't that read as
>
> +ifeq (${ns_self_contained},yes)
>
> I'm confused...
I assume that is nextstep/Makefile.in. We want to cp the .pdmp file
only if we don't do a self-contained build (...=no).
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d
2023-09-21 8:46 ` Gerd Möllmann
@ 2023-09-21 9:59 ` Pedro Andres Aranda Gutierrez
2023-09-21 10:22 ` Gerd Möllmann
2023-09-21 16:50 ` Alan Third
1 sibling, 1 reply; 9+ messages in thread
From: Pedro Andres Aranda Gutierrez @ 2023-09-21 9:59 UTC (permalink / raw)
To: Gerd Möllmann; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]
Thank you for the clarification!
The FIXME was sort of misleading here. A double negation always is ;-)
Best, /PA
On Thu, 21 Sept 2023 at 10:47, Gerd Möllmann <gerd.moellmann@gmail.com>
wrote:
> On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
> > Hi
> >
> > reading removed FIXME in the second hunk:
> >
> > # FIXME: Don't install the dump file into the app bundle when
> > # self-contained install is disabled.
> >
> > I understand that we should install if self-contained is enabled.
> >
> > However, I see
> >
> > +ifeq (${ns_self_contained},no)
> >
> > Shouldn't that read as
> >
> > +ifeq (${ns_self_contained},yes)
> >
> > I'm confused...
>
> I assume that is nextstep/Makefile.in. We want to cp the .pdmp file
> only if we don't do a self-contained build (...=no).
>
>
--
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler
Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet
[-- Attachment #2: Type: text/html, Size: 1763 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d
2023-09-21 8:46 ` Gerd Möllmann
2023-09-21 9:59 ` Pedro Andres Aranda Gutierrez
@ 2023-09-21 16:50 ` Alan Third
2023-09-21 17:06 ` Gerd Möllmann
1 sibling, 1 reply; 9+ messages in thread
From: Alan Third @ 2023-09-21 16:50 UTC (permalink / raw)
To: Gerd Möllmann; +Cc: emacs-devel
On Thu, Sep 21, 2023 at 10:46:56AM +0200, Gerd Möllmann wrote:
> On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
> > Hi
> >
> > reading removed FIXME in the second hunk:
> >
> > # FIXME: Don't install the dump file into the app bundle when
> > # self-contained install is disabled.
> >
> > I understand that we should install if self-contained is enabled.
> >
> > However, I see
> >
> > +ifeq (${ns_self_contained},no)
> >
> > Shouldn't that read as
> >
> > +ifeq (${ns_self_contained},yes)
> >
> > I'm confused...
>
> I assume that is nextstep/Makefile.in. We want to cp the .pdmp file only if
> we don't do a self-contained build (...=no).
Now I'm confused!
We only have to install the pdmp file in the app bundle when doing a
self-contained build.
If your other change in Makefile.in already does that, then this cp
isn't needed at all.
--
Alan Third
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d
2023-09-21 16:50 ` Alan Third
@ 2023-09-21 17:06 ` Gerd Möllmann
2023-09-21 17:29 ` Alan Third
0 siblings, 1 reply; 9+ messages in thread
From: Gerd Möllmann @ 2023-09-21 17:06 UTC (permalink / raw)
To: Alan Third, emacs-devel
On 23-09-21 18:50 , Alan Third wrote:
> On Thu, Sep 21, 2023 at 10:46:56AM +0200, Gerd Möllmann wrote:
>> On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
>>>> I'm confused...
>>
>> I assume that is nextstep/Makefile.in. We want to cp the .pdmp file only if
>> we don't do a self-contained build (...=no).
>
> Now I'm confused!
I suspect you're all trying to confuse me :-).
> We only have to install the pdmp file in the app bundle when doing a
> self-contained build.
>
> If your other change in Makefile.in already does that, then this cp
> isn't needed at all.
>
My aim was to not change anything in the case the build is not
self-contained, because I can't test that.
In nextstep/Makefile.in, the cp
- is not done in the self-contained case
- is done for the non-self-contained case
(This cp was formerly done for a naked make at toplevel, not only for a
make install. That was the problem resulting in an inconistent Emacs.app.)
In the toplevel Makefile.in
- the install is done in the self-contained case, as a substitute for
the now missing cp in nextstep/Makefile.in
- nothing is changed for the non-self-contained case
(This happens when we make install.)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d
2023-09-21 17:06 ` Gerd Möllmann
@ 2023-09-21 17:29 ` Alan Third
2023-09-21 17:58 ` Gerd Möllmann
0 siblings, 1 reply; 9+ messages in thread
From: Alan Third @ 2023-09-21 17:29 UTC (permalink / raw)
To: Gerd Möllmann; +Cc: emacs-devel
On Thu, Sep 21, 2023 at 07:06:20PM +0200, Gerd Möllmann wrote:
> On 23-09-21 18:50 , Alan Third wrote:
> > On Thu, Sep 21, 2023 at 10:46:56AM +0200, Gerd Möllmann wrote:
> > > On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote:
> > > > > I'm confused...
> > >
> > > I assume that is nextstep/Makefile.in. We want to cp the .pdmp file only if
> > > we don't do a self-contained build (...=no).
> >
> > Now I'm confused!
>
> I suspect you're all trying to confuse me :-).
>
> > We only have to install the pdmp file in the app bundle when doing a
> > self-contained build.
> >
> > If your other change in Makefile.in already does that, then this cp
> > isn't needed at all.
> >
> My aim was to not change anything in the case the build is not
> self-contained, because I can't test that.
>
> In nextstep/Makefile.in, the cp
> - is not done in the self-contained case
> - is done for the non-self-contained case
> (This cp was formerly done for a naked make at toplevel, not only for a make
> install. That was the problem resulting in an inconistent Emacs.app.)
>
> In the toplevel Makefile.in
> - the install is done in the self-contained case, as a substitute for the
> now missing cp in nextstep/Makefile.in
> - nothing is changed for the non-self-contained case
> (This happens when we make install.)
OK. As the author of that line of code and the FIXME I would recommend
removing the cp in nextstep/Makefile.in for the non-self-contained
case as well, but I don't think I can prove that it's not going to
break anything as I can't really test it either! :)
I guess I can just remove it myself...
--
Alan Third
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-09-21 18:46 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-21 6:29 Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d Pedro Andres Aranda Gutierrez
2023-09-21 8:46 ` Gerd Möllmann
2023-09-21 9:59 ` Pedro Andres Aranda Gutierrez
2023-09-21 10:22 ` Gerd Möllmann
2023-09-21 16:50 ` Alan Third
2023-09-21 17:06 ` Gerd Möllmann
2023-09-21 17:29 ` Alan Third
2023-09-21 17:58 ` Gerd Möllmann
2023-09-21 18:46 ` Alan Third
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).